Closed marceloavf closed 6 years ago
What are this third party changes about?
Oh I see... it's the first commit: update: typeahead from v3.0.3 to v4.0.2
Does this allow to hit Enter after entering a github username
to jump to the repo
field?
For now it doesn't, could be a great idea, it only trigger the button when you choose an option of repository, avoiding you to hit Tab and then Enter or using the mouse
Before:
1. Type an username, Tab
2. Type an repository, choose one from the list using arrows, clicking or/and hitting Enter
3. Hit Tab and then Enter or click in the button
Now:
1. Type an username, Tab 2. Type an repository, choose one from the list using arrows, clicking or/and hitting Enter and it automatically search it
Now:
- Type an username, Tab
- Type an repository, choose one from the list using arrows, clicking or/and hitting Enter and it automatically search it
That's a huge improvement. No complains there.
But don't forget that any mobile device has no Tab
button, that's why I double checked/suggested the Enter to make the jump from username to repo, too.
Uniform behavior and benefit for all users, no matter which device they run the request from.
Great point, I did not think of that, I'll implement it for sure! Thanks!
Tested with your demo link again - seems to work!
Thanks for the patch!
For better accessibility, allow to auto search after user select one option with enter, tab or click action.