search

SonarQubeCommunity / sonar-pdf-report

80 stars 81 forks source link

Fixed problem with removed parameter "scopes" #2

Closed cervenkap closed 10 years ago

cervenkap commented 10 years ago

From Sonar version 3.6 and latter is removed parameter "scopes"; was used at URL for PDF report generation. This parameter was at code for backward comp. only, because it was typo error. Standard parameter name is "scope". So "scopes" was replaced by "scope" at this update. Related ticket at JIRA - SONARPLUGINS-3020.

amuniz commented 10 years ago

Hello,

Thanks for the patch.

Unfortunately I can't accept it. Perhaps your patch fixes the problem, but it's only a "partial" fix, because the right way to fix the compatibility issue with Sonar 3.6+ is replacing every call to the violations endpoint by calling the new issues endpoint.

Regards, Antonio.

cervenkap commented 10 years ago

Hello Antonio, thank you for your comment. I understand your idea to keep code clean and following the latest Sonar "APIs". BUT by this approach you are preventing to use your Sonar PDF plugin by public audience till time, when you or somebody else creates new version which follows "APIs". And it could take longer time. So even this is "partial" patch it will allow to use PDF plugin with new version of Sonar right now ... (and offers more "space/time" to work on new API integration) - maybe "iteration" approach will be better :-) BTW I was looking to new API "issues" and my opinion is that is "purpose" is totally different (aimed to issues tracking ...) then is deprecated "violations" and I think that will not be easy to switch from "violations" to "issues". Sonar authors should provide some "migration guide" for this ... Best regards, Pavel C.