search

SonarSoftwareInc / customer_portal

A prebuilt customer portal for Sonar.
https://sonar.software
25 stars 51 forks source link

Initial portal config validation error #3

Closed gmcintire closed 5 years ago

gmcintire commented 5 years ago

Location: Immediately after installing via docker instructions and visiting portal.domain.name/settings

Problem: Leaving any fields out that will throw a validation error (such as email settings) result in flash messages after being redirected to / (not /settings), thereby losing anything previously entered in config.

SonarSoftware commented 5 years ago

@zulandar Please take a look at this one too.

gmcintire commented 5 years ago

Additional bug: when returning to the settings screen after initial config, making no changes, and submitting will always delete the custom logo.

zulandar commented 5 years ago

@gmcintire I have tested the first issue with only setting application URL and ticketing settings. (leaving email settings blank). and when I click save both in Chrome/Firebox I get the validation error flash message and the settings I set are still in the fields. I've tried this from a fresh install as well.

I am still looking at the custom logo

zulandar commented 5 years ago

@gmcintire can you attempt to reproduce this issue?

This may of been resolved with the JS fixes as of right now I am not able to reproduce the issue within DO or locally.

zulandar commented 5 years ago

Resolved in PR #2