SonarSonic / Flux-Networks

Wireless Energy - Minecraft Forge Mod
MIT License
111 stars 62 forks source link

[1.10.2] Networks are forgotten after most restarts #75

Closed Brend-Smits closed 7 years ago

Brend-Smits commented 7 years ago

Running modpack : Sky Factory 3 (recommended version) Whenever you make a new network and save it, after most server restarts, saved networks will simply be gone and it will be like they never existed. Running: FluxNetworks-1.10.2-1.1.7

SonarSonic commented 7 years ago

Try version 1.2.0 if you are still having the problem then let me know.

Brend-Smits commented 7 years ago

Unfortunately I can't put version 1.2 on the server due to the clients needing to switch as well, any other ideas? Thanks for the comment!

SonarSonic commented 7 years ago

It's an issue I fixed in a more recent version. No other way to fix it sorry.

Brend-Smits commented 7 years ago

Alright glad to know it's fixed in more recent versions. I will see what I can do on my test server ^^

Speiger commented 7 years ago

@SonarSonic is this issue a ServerSide Only issue? Or did you do since these newer versions only serverside fixes? If yes could you export a Special version for him with the hardcoded version he uses at the moment? If there are only server side fixes then this is no problem. Even if there are client sided fixes as long nothing with Networking between Server&Client is changed this can be done too without any bugs between these versions.

Brend-Smits commented 7 years ago

I would have changed the version number, I'm just scared for client desyncronisations as the developer added a new GUI button to delete networks. Which will cause the server/client to desync. That's the only problem I can see according to change logs.

Speiger commented 7 years ago

@Rubbertjuh this would be a issue if the client is updated and the server is outdated. Otherwise its possible as long he didnt change how he received the messages and processed them. In other words: If he only added the feature new then this is basically a feature that will be never called. If he did add new things like new packets for that and resorted the processing of the interactions then its a problem. Its always a Point of view.

Brend-Smits commented 7 years ago

Any idea @SonarSonic if it will impact the client at all if I update it server side only?

SonarSonic commented 7 years ago

I shouldn't do, but the clients will probably not be able to logon because the version numbers will be different.

Brend-Smits commented 7 years ago

@SonarSonic I will change the version number by bytecode editing the version string. So you do not think the button will cause the server / client will desync and cause disconnects?

SonarSonic commented 7 years ago

nope not at all.

Brend-Smits commented 7 years ago

Fantastic, thank you for the comment! I will let you know if it's fixed

Speiger commented 7 years ago

@SonarSonic for later versions i habe a suggestion: only update Version numbers Ehen networking has changed. It makes fixes for modpacks and serverowners mich easier.

Brend-Smits commented 7 years ago

image As you can see, my players are very happy with this update ^.^ Thanks for the help!

Brend-Smits commented 7 years ago

Unfortunately I have to reopen this issue as in 1.2.0 the version is still present. This time I caught an error! https://hastebin.com/xihexuqiga.md

Renetje666 commented 7 years ago

Also i get problems with this mod. Plugs stop sending RF over network. When i remove plug and place again it will work again (version flux 1,2 (hermitcraft)). No server just local game.

SonarSonic commented 7 years ago

Okay hopefully should be fixed again now @Rubbertjuh

Brend-Smits commented 7 years ago

Thank you @SonarSonic for your swift support as always, I will put in the latest build and see if it's fixed! - When it's available ;)

SonarSonic commented 7 years ago

wait for 1.2.1. Hopefully should be a number of fixes

Brend-Smits commented 7 years ago

When will 1.2.1 come out @SonarSonic ? ^^

SonarSonic commented 7 years ago

@Rubbertjuh Tonight