search

SonarSource / sonar-dotnet

Code analyzer for C# and VB.NET projects
https://redirect.sonarsource.com/plugins/csharp.html
GNU Lesser General Public License v3.0
772 stars 226 forks source link

Fix the "valid.xml" OpenCover test case #4038

Open andrei-epure-sonarsource opened 3 years ago

andrei-epure-sonarsource commented 3 years ago

The current test case for a valid OpenCover report ("valid.xml") creates noise when being parsed.

OpenCover parser: invalid start line for file (ID '3', path 'MyLibrary\Adder.cs', indexed as ...

This should not happen for valid XML. We should regenerate this test case. But bear in mind the OpenCover versioning. We need to use also an older open cover format which doesn't have the "fileid" in the SequencePoint attribute. Otherwise, we'll lose coverage.

Alternatively, we can decide to drop this "RefFile" UID fallback feature - must investigate in which OpenCover version it got dropped (if in any).

Tim-Pohlmann commented 1 month ago

I updated priority and effort and moved this back to the backlog.