Fix error MSB4062 and add bUnit to peach

[antonioaversa]

peachee-dotnet PRs:

• https://github.com/SonarSource/peachee-dotnet/pull/46 - closed as replaced by following PRs
• https://github.com/SonarSource/peachee-dotnet/pull/53 for PrivateProxy only - merged
• https://github.com/SonarSource/peachee-dotnet/pull/52 for bunit only - closed as replaced by following PR
• https://github.com/SonarSource/peachee-dotnet/pull/54 - merged

Requirements

• good coverage of .NET 8 and C# 12 features
• razor/cshtml files for MMF-3457 (5 rules for Blazor)

Projects selected

• bUnit is a rather well-established library for Blazor components testing.
  • It's small enough to be built quickly and has green CI, yet its main already targets net8.0 and contains some .NET 8 features (such as UnsafeAccessor).
  • On top, it has razor files in it, which helps with our testing of razor support and future development of rules for Blazor.
• PrivateProxy is a very small, .NET8 and C# 12-only, 3-month-old library developed by a MS Employee, that takes advantage of source gens and .NET 8 unsafe accessors to provide cost-free access to private fields.
  • It's production code, v1 has been released and there is green CI.
  • However there is not a lot of code in there, and the future of the lib may be uncertain (i.e. the repo may disappear one day).

Green run on peach:

https://cirrus-ci.com/build/6148892283109376

[antonioaversa]

Current status: Last run on peach: https://cirrus-ci.com/build/5980137078915072 Both projects (bunit and PrivateProperty) fail with the following error:

C:\nuget\microsoft.build.tasks.git\1.1.1\build\Microsoft.Build.Tasks.Git.targets(25,5): 
error MSB4062: The "Microsoft.Build.Tasks.Git.LocateRepository" task could not be loaded from the assembly
C:\nuget\microsoft.build.tasks.git\1.1.1\build\..\tools\core\Microsoft.Build.Tasks.Git.dll. 
Assembly with same name is already loaded 
Confirm that the <UsingTask> declaration is correct, that the assembly and all its dependencies are available, 
and that the task contains a public class that implements Microsoft.Build.Framework.ITask.
[C:\Project\src\bunit.web\bunit.web.csproj::TargetFramework=net8.0]

This is already happening on the peachee-dotnet analyses of master: e.g. in orchard-core and piranha-core.

C:\Program Files\dotnet\sdk\8.0.100-rc.2.23502.2\Sdks\Microsoft.Build.Tasks.Git\build\Microsoft.Build.Tasks.Git.targets(25,5):
error MSB4062: The "Microsoft.Build.Tasks.Git.LocateRepository" task could not be loaded from the assembly 
C:\Program Files\dotnet\sdk\8.0.100-rc.2.23502.2\Sdks\Microsoft.Build.Tasks.Git\build\..\tools\core\Microsoft.Build.Tasks.Git.dll.
Assembly with same name is already loaded
Confirm that the <UsingTask> declaration is correct, that the assembly and all its dependencies are available, 
and that the task contains a public class that implements Microsoft.Build.Framework.ITask. [C:\Project\src\docs\OrchardCore.Docs.csproj::TargetFramework=net7.0]

[antonioaversa]

An internal background task was created, to follow up on this issue, that is non-blocking for MMF-3410

I have then removed the "MMF-3410" label from this issue, and added the "MMF-3457", since having bunit on peach will help peach validating the new rules for Blazor.

[antonioaversa]

This issue has been completed and moved to Done on Nov 6, 2023. The integration should have moved closed the issue as well. Closing as completed.