SonarSource / sonar-go-archived

SonarGo: Go Analyzer for SonarQube
https://docs.sonarqube.org/display/PLUG/SonarGo
Other
120 stars 24 forks source link

Rule S1763 FN: fix multiple jumps scenario #345

Closed lonegunmanb closed 5 years ago

lonegunmanb commented 5 years ago

origin code checks for LABEL statement only once, so it'll failed in a method with multiple jumps.

lonegunmanb commented 5 years ago

By the way, travis build failed info: Copy public Maven settings Setting .npmrc ./travis.sh: line 30: SONAR_HOST_URL: unbound variable The command "./travis.sh" exited with 1. so, it's not my patch's problem?

saberduck commented 5 years ago

Thank you for your contribution @lonegunmanb ! There is some issue with our CI setup, I had to reopen the PR #374 , so I am going to close this one and merge the other one.

lonegunmanb commented 5 years ago

glad to hear that!