SonarSource / sonar-loc-count

GNU Lesser General Public License v3.0
37 stars 27 forks source link

Fix and Improvements Github LOC #20

Closed gabrielsoltz closed 1 year ago

gabrielsoltz commented 1 year ago

The github_com.sh has several bugs and problems:

Now, when no repository is passed as an argument, the code will count the total amount of repositories in GitHub and, based on that, configure itself for iterating/paginating the results. You don't need to hardcode the code anymore. If a repository is passed as an argument, it will only scan that repository (as before).

The code is now also parsing each repository's archived field. If the repository is archived, it will not be analyzed.

sylvain-combe-sonarsource commented 1 year ago

Hi @gabrielsoltz It may take some time for us to validate your PR, but many thanks for assembling it.

@emmanuel-colussi-sonarsource I believe we had the possibility to recurse in GitHub paginated answers, and it looks like we had a regression with one of your commits. The easiest fix is probably to merge this PR, and benefit from this new filter on archived projects in the process :-)