Sonarr / Sonarr

Smart PVR for newsgroup and bittorrent users.
https://sonarr.tv
GNU General Public License v3.0
10.61k stars 1.34k forks source link

UpgradeAllowedSpecification & CutoffSpecification - File vs. Release Quality compare - Missing Variables to be logged. #5242

Closed bakerboy448 closed 1 year ago

bakerboy448 commented 1 year ago

Is there an existing issue for this?

Current Behavior

2022-11-25 21:02:18.3|Debug|UpgradeAllowedSpecification|Comparing file quality with report. Existing file is {0} - {1} 2022-11-25 21:02:18.3|Debug|CutoffSpecification|Comparing file quality with report. Existing file is {0} - {1}

Expected Behavior

Variables should be populated

Steps To Reproduce

N/A - Logging issue.

Environment

- OS: agnostic 
- Sonarr: 4.0.0.178
- Docker Install: agnostic
- Using Reverse Proxy: agnostic
- Browser: agnostic

What branch are you running?

Develop

Trace Logs?

2022-11-25 21:02:18.3|Debug|DownloadDecisionMaker|Processing release 'The Kardashians S02E10 Heres To Paris 2160p HULU WEB-DL DDP 5.1 H 265-NTb' from 'BeyondHD (Prowlarr)'
2022-11-25 21:02:18.3|Debug|Parser|Parsing string 'The Kardashians S02E10 Heres To Paris 2160p HULU WEB-DL DDP 5.1 H 265-NTb'
2022-11-25 21:02:18.3|Trace|Parser|^(?<title>.+?)(?:(?:[-_\W](?<![()\[!]))+S?(?<season>(?<!\d+)(?:\d{1,2})(?!\d+))(?:[ex]|\W[ex]){1,2}(?<episode>\d{2,3}(?!\d+))(?:(?:\-|[ex]|\W[ex]|_){1,2}(?<episode>\d{2,3}(?!\d+)))*)\W?(?!\\)
2022-11-25 21:02:18.3|Debug|Parser|Episode Parsed. The Kardashians - S02E10 
2022-11-25 21:02:18.3|Debug|Parser|Languages parsed: Unknown
2022-11-25 21:02:18.3|Debug|QualityParser|Trying to parse quality for The Kardashians S02E10 Heres To Paris 2160p HULU WEB-DL DDP 5.1 H 265-NTb
2022-11-25 21:02:18.3|Debug|Parser|Quality parsed: WEBDL-2160p v1
2022-11-25 21:02:18.3|Debug|Parser|Release Group parsed: NTb
2022-11-25 21:02:18.3|Debug|ParsingService|Language couldn't be parsed from release, fallback to series original language: English
2022-11-25 21:02:18.3|Debug|AcceptableSizeSpecification|Beginning size check for: The Kardashians S02E10 Heres To Paris 2160p HULU WEB-DL DDP 5.1 H 265-NTb
2022-11-25 21:02:18.3|Debug|AcceptableSizeSpecification|Possible double episode, doubling allowed size.
2022-11-25 21:02:18.3|Debug|AcceptableSizeSpecification|Item: The Kardashians S02E10 Heres To Paris 2160p HULU WEB-DL DDP 5.1 H 265-NTb, meets size constraints
2022-11-25 21:02:18.3|Debug|AlreadyImportedSpecification|Performing already imported check on report
2022-11-25 21:02:18.3|Debug|CutoffSpecification|Comparing file quality with report. Existing file is {0} - {1}
2022-11-25 21:02:18.3|Trace|ConfigService|Using default config value for 'maximumsize' defaultValue:'0'
2022-11-25 21:02:18.3|Debug|MaximumSizeSpecification|Maximum size is not set.
2022-11-25 21:02:18.3|Debug|MinimumAgeSpecification|Not checking minimum age requirement for non-usenet report
2022-11-25 21:02:18.3|Debug|QualityAllowedByProfileSpecification|Checking if report meets quality requirements. WEBDL-2160p v1
2022-11-25 21:02:18.3|Debug|QualityAllowedByProfileSpecification|Quality WEBDL-2160p v1 rejected by Series' quality profile
2022-11-25 21:02:18.3|Debug|ReleaseRestrictionsSpecification|Checking if release meets restrictions: The Kardashians S02E10 Heres To Paris 2160p HULU WEB-DL DDP 5.1 H 265-NTb
2022-11-25 21:02:18.3|Debug|ReleaseRestrictionsSpecification|[The Kardashians S02E10 Heres To Paris 2160p HULU WEB-DL DDP 5.1 H 265-NTb] No restrictions apply, allowing
2022-11-25 21:02:18.3|Debug|RetentionSpecification|Not checking retention requirement for non-usenet report
2022-11-25 21:02:18.3|Debug|UpgradeAllowedSpecification|Comparing file quality with report. Existing file is {0} - {1}
2022-11-25 21:02:18.3|Debug|UpgradeDiskSpecification|Comparing file quality with report. Existing file is WEBDL-720p v1
2022-11-25 21:02:18.3|Debug|UpgradableSpecification|Existing item has better quality, skipping

Anything else?

n/a

thezoggy commented 1 year ago

- {1} left when language was dropped, happened in a few spots

https://github.com/Sonarr/Sonarr/blob/f47abd0d99719907c734bab0f2ef5477d2054d0d/src/NzbDrone.Core/DecisionEngine/Specifications/CutoffSpecification.cs#L39

https://github.com/Sonarr/Sonarr/blob/f47abd0d99719907c734bab0f2ef5477d2054d0d/src/NzbDrone.Core/DecisionEngine/Specifications/UpgradeAllowedSpecification.cs#L34

Qstick commented 1 year ago

The PR for this might have been quicker than the issue you wrote Baker.