search

Sonarr / Sonarr

Smart PVR for newsgroup and bittorrent users.
https://sonarr.tv
GNU General Public License v3.0
10.64k stars 1.35k forks source link

Files/Folders no longer being deleted after import #7043

Closed gold007eye closed 1 month ago

gold007eye commented 1 month ago

Is there an existing issue for this?

Current Behavior

Files and Folders are now remaining in the original download folder since 'Fixed: Import with copy from download clients with remove completed disabled #7031' this was implemented in the latest release 7/31/2024 v4.0.8.1988.

Expected Behavior

After episode is downloaded and imported Sonarr should be removing the folder and files from the original download location.

Steps To Reproduce

Update to 4.0.8.1988 Have sonarr auto grab a tv show episode. When it imports it, the original files and folders now remain in the original download client folder even though the files have been copied to the TV Show final folder.

Before this update I never had the SABNzbd Client option of "Remove Completed" enabled. Reason was I would manually check speeds and would clear this from SABnzbd manually. Before the latest update files & folders would still get deleted. After the update this no longer works unless I check the "Remove Completed" checkbox under the client settings.

Environment

- OS: 
- Sonarr: 
- Docker Install: Hotio
- Using Reverse Proxy: No
- Browser: FireFox
- Database:

What branch are you running?

Develop

Trace Logs?

2024-07-31 10:52:27.9|Debug|VideoFileInfoReader|Getting media info from /config/plex/TV Shows - Temp/Cops S30E03 1080p AMZN WEB-DL DD2 0 x264-TrollHD/Cops.S30E03.Surprise.Guest.1080p.Amazon.WEB-DL.DD.2.0.x264-TrollHD.mkv 2024-07-31 10:52:27.9|Debug|Parser|Parsing string 'Cops.S30E03.Surprise.Guest.1080p.Amazon.WEB-DL.DD.2.0.x264-TrollHD' 2024-07-31 10:52:27.9|Trace|Parser|^(?<title>.+?)(?:(?:[-_\W](?<![()\[!]))+S?(?<season>(?<!\d+)(?:\d{1,2})(?!\d+))(?:[ex]|\W[ex]){1,2}(?<episode>\d{2,3}(?!\d+))(?:(?:\-|[ex]|\W[ex]|_){1,2}(?<episode>\d{2,3}(?!\d+)))*)(?:[-_. ]|$) 2024-07-31 10:52:27.9|Debug|Parser|Episode Parsed. Cops - S30E03 2024-07-31 10:52:27.9|Debug|Parser|Languages parsed: Unknown 2024-07-31 10:52:27.9|Debug|QualityParser|Trying to parse quality for 'Cops.S30E03.Surprise.Guest.1080p.Amazon.WEB-DL.DD.2.0.x264-TrollHD' 2024-07-31 10:52:27.9|Debug|Parser|Quality parsed: WEBDL-1080p v1 2024-07-31 10:52:27.9|Debug|Parser|Release Group parsed: TrollHD 2024-07-31 10:52:27.9|Trace|AggregateLanguage|Considering Languages (Filename) from FileName 2024-07-31 10:52:27.9|Trace|AggregateLanguage|Considering Languages (Foldername) from FolderName 2024-07-31 10:52:27.9|Trace|AggregateLanguage|Considering Languages (DownloadClientItem) from DownloadClientItem 2024-07-31 10:52:27.9|Trace|AggregateLanguage|Considering Languages English (MediaInfo) from MediaInfo 2024-07-31 10:52:27.9|Debug|AggregateLanguage|Selected languages: English 2024-07-31 10:52:27.9|Trace|AggregateQuality|Considering Source Web (Tag) Resolution 1080 (Tag) Revision v1 from FileName 2024-07-31 10:52:27.9|Trace|AggregateQuality|Considering Source Web (Tag) Resolution 1080 (Tag) Revision v1 from FolderName 2024-07-31 10:52:27.9|Trace|AggregateQuality|Considering Source Web (Tag) Resolution 1080 (Tag) Revision v1 from DownloadClientItem 2024-07-31 10:52:27.9|Trace|AugmentQualityFromMediaInfo|Resolution 1920x1080 considered 1080p 2024-07-31 10:52:27.9|Trace|AggregateQuality|Considering Source Unknown (Default) Resolution 1080 (MediaInfo) Revision from MediaInfo 2024-07-31 10:52:27.9|Debug|QualityParser|Trying to parse quality for 'Cops.S30E03.1080p.AMZN.WEB-DL.DD2.0.x264-TrollHD' 2024-07-31 10:52:27.9|Trace|AggregateQuality|Considering Source Web (Tag) Resolution 1080 (Tag) Revision v1 from ReleaseName 2024-07-31 10:52:27.9|Trace|AggregateQuality|Selected Source Web (Tag) Resolution 1080 (MediaInfo) Revision v1 2024-07-31 10:52:27.9|Debug|AggregateQuality|Using quality: WEBDL-1080p v1 2024-07-31 10:52:27.9|Debug|AbsoluteEpisodeNumberSpecification|Series type is not Anime, skipping check 2024-07-31 10:52:27.9|Debug|AlreadyImportedSpecification|Skipping already imported check for episode without file 2024-07-31 10:52:27.9|Trace|ConfigService|Using default config value for 'episodetitlerequired' defaultValue:'Always' 2024-07-31 10:52:27.9|Debug|EpisodeTitleSpecification|Episode aired more than 48 hours ago 2024-07-31 10:52:27.9|Trace|ConfigService|Using default config value for 'skipfreespacecheckwhenimporting' defaultValue:'False' 2024-07-31 10:52:27.9|Trace|ConfigService|Using default config value for 'minimumfreespacewhenimporting' defaultValue:'100' 2024-07-31 10:52:27.9|Debug|VideoFileInfoReader|Getting media info from /config/plex/TV Shows - Temp/Cops S30E03 1080p AMZN WEB-DL DD2 0 x264-TrollHD/Cops.S30E03.Surprise.Guest.1080p.Amazon.WEB-DL.DD.2.0.x264-TrollHD.mkv 2024-07-31 10:52:27.9|Debug|DetectSample|[/config/plex/TV Shows - Temp/Cops S30E03 1080p AMZN WEB-DL DD2 0 x264-TrollHD/Cops.S30E03.Surprise.Guest.1080p.Amazon.WEB-DL.DD.2.0.x264-TrollHD.mkv] does not appear to be a sample. Runtime 00:20:31.1630000 seconds is more than minimum of 300 seconds 2024-07-31 10:52:27.9|Trace|ConfigService|Using default config value for 'downloadclientworkingfolders' defaultValue:'_UNPACK_|_FAILED_' 2024-07-31 10:52:27.9|Debug|ImportDecisionMaker|File accepted 2024-07-31 10:52:27.9|Trace|ConfigService|Using default config value for 'copyusinghardlinks' defaultValue:'True' 2024-07-31 10:52:27.9|Debug|EpisodeFileMovingService|Attempting to hardlink episode file: /config/plex/TV Shows - Temp/Cops S30E03 1080p AMZN WEB-DL DD2 0 x264-TrollHD/Cops.S30E03.Surprise.Guest.1080p.Amazon.WEB-DL.DD.2.0.x264-TrollHD.mkv to /config/plex/TV Shows/Cops (1989)/Season 30/Cops (1989) S30E03 - Surprise Guest [AMZN WEBDL-1080p][EAC3 2.0][x264]-TrollHD.mkv 2024-07-31 10:52:28.0|Trace|ConfigService|Using default config value for 'usescriptimport' defaultValue:'False' 2024-07-31 10:52:28.0|Debug|DiskTransferService|HardLinkOrCopy [/config/plex/TV Shows - Temp/Cops S30E03 1080p AMZN WEB-DL DD2 0 x264-TrollHD/Cops.S30E03.Surprise.Guest.1080p.Amazon.WEB-DL.DD.2.0.x264-TrollHD.mkv] > [/config/plex/TV Shows/Cops (1989)/Season 30/Cops (1989) S30E03 - Surprise Guest [AMZN WEBDL-1080p][EAC3 2.0][x264]-TrollHD.mkv] 2024-07-31 10:52:28.0|Trace|ConfigService|Using default config value for 'filedate' defaultValue:'None' 2024-07-31 10:52:28.0|Trace|ConfigService|Using default config value for 'setpermissionslinux' defaultValue:'False' 2024-07-31 10:52:28.1|Trace|EventAggregator|Publishing EpisodeFileAddedEvent 2024-07-31 10:52:28.1|Trace|EventAggregator|EpisodeFileAddedEvent -> EpisodeService 2024-07-31 10:52:28.1|Trace|EventAggregator|Publishing ModelEvent<Episode> 2024-07-31 10:52:28.1|Trace|EventAggregator|ModelEvent<Episode> -> CutoffController 2024-07-31 10:52:28.1|Trace|CustomFormatCalculationService|Using scene name for release title: Cops S30E03 1080p AMZN WEB-DL DD2 0 x264-TrollHD 2024-07-31 10:52:28.1|Trace|EventAggregator|ModelEvent<Episode> <- CutoffController 2024-07-31 10:52:28.1|Trace|EventAggregator|ModelEvent<Episode> -> MissingController 2024-07-31 10:52:28.1|Trace|CustomFormatCalculationService|Using scene name for release title: Cops S30E03 1080p AMZN WEB-DL DD2 0 x264-TrollHD 2024-07-31 10:52:28.1|Trace|EventAggregator|ModelEvent<Episode> <- MissingController 2024-07-31 10:52:28.1|Trace|EventAggregator|ModelEvent<Episode> -> EpisodeController 2024-07-31 10:52:28.1|Trace|CustomFormatCalculationService|Using scene name for release title: Cops S30E03 1080p AMZN WEB-DL DD2 0 x264-TrollHD 2024-07-31 10:52:28.1|Trace|EventAggregator|ModelEvent<Episode> <- EpisodeController 2024-07-31 10:52:28.1|Trace|EventAggregator|ModelEvent<Episode> -> CalendarController 2024-07-31 10:52:28.1|Trace|CustomFormatCalculationService|Using scene name for release title: Cops S30E03 1080p AMZN WEB-DL DD2 0 x264-TrollHD 2024-07-31 10:52:28.1|Trace|EventAggregator|ModelEvent<Episode> <- CalendarController 2024-07-31 10:52:28.1|Debug|EpisodeService|Linking [Season 30/Cops (1989) S30E03 - Surprise Guest [AMZN WEBDL-1080p][EAC3 2.0][x264]-TrollHD.mkv] > [[54379]Surprise Guest] 2024-07-31 10:52:28.1|Trace|EventAggregator|EpisodeFileAddedEvent <- EpisodeService 2024-07-31 10:52:28.1|Trace|EventAggregator|EpisodeFileAddedEvent -> EpisodeFileController 2024-07-31 10:52:28.1|Trace|CustomFormatCalculationService|Using scene name for release title: Cops S30E03 1080p AMZN WEB-DL DD2 0 x264-TrollHD 2024-07-31 10:52:28.1|Trace|EventAggregator|EpisodeFileAddedEvent <- EpisodeFileController 2024-07-31 10:52:28.1|Trace|ConfigService|Using default config value for 'importextrafiles' defaultValue:'False' 2024-07-31 10:52:28.1|Trace|EventAggregator|Publishing EpisodeImportedEvent 2024-07-31 10:52:28.1|Trace|EventAggregator|EpisodeImportedEvent -> NotificationService 2024-07-31 10:52:28.1|Debug|NotificationService|No tags set for this notification. 2024-07-31 10:52:28.1|Trace|ConfigService|Using default config value for 'applicationurl' defaultValue:'' 2024-07-31 10:52:28.1|Trace|HttpClient|Req: [POST] https://notifiarr.com/api/v1/notification/sonarr 2024-07-31 10:52:28.1|Trace|ConfigService|Using default config value for 'proxyenabled' defaultValue:'False' 2024-07-31 10:52:29.1|Trace|HttpClient|Res: HTTP/2.0 [POST] https://notifiarr.com/api/v1/notification/sonarr: 200.OK (265 bytes) (983 ms) 2024-07-31 10:52:29.1|Debug|NotificationService|No tags set for this notification. 2024-07-31 10:52:29.1|Trace|HttpClient|Req: [POST] https://api.pushover.net/1/messages.json: token=(removed)&user=(removed)&device=&title=Episode%20Downloaded&message=Cops%20-%2030x03%20-%20Surprise%20Guest%20%5BWEBDL-1080p%5D&priority=0&sound=tugboat 2024-07-31 10:52:29.1|Trace|ConfigService|Using default config value for 'proxyenabled' defaultValue:'False' 2024-07-31 10:52:29.5|Trace|HttpClient|Res: HTTP/2.0 [POST] https://api.pushover.net/1/messages.json: 200.OK (61 bytes) (394 ms) 2024-07-31 10:52:29.5|Trace|EventAggregator|EpisodeImportedEvent <- NotificationService 2024-07-31 10:52:29.5|Trace|EventAggregator|EpisodeImportedEvent -> HistoryService 2024-07-31 10:52:29.6|Trace|EventAggregator|EpisodeImportedEvent <- HistoryService 2024-07-31 10:52:29.6|Trace|EventAggregator|EpisodeImportedEvent -> DownloadMonitoringService 2024-07-31 10:52:29.6|Trace|EventAggregator|EpisodeImportedEvent <- DownloadMonitoringService 2024-07-31 10:52:29.6|Trace|EventAggregator|EpisodeImportedEvent -> DownloadHistoryService 2024-07-31 10:52:29.7|Trace|EventAggregator|EpisodeImportedEvent <- DownloadHistoryService 2024-07-31 10:52:29.7|Trace|EventAggregator|EpisodeImportedEvent -> CutoffController 2024-07-31 10:52:29.7|Trace|CustomFormatCalculationService|Using scene name for release title: Cops S30E03 1080p AMZN WEB-DL DD2 0 x264-TrollHD 2024-07-31 10:52:29.7|Trace|EventAggregator|EpisodeImportedEvent <- CutoffController 2024-07-31 10:52:29.7|Trace|EventAggregator|EpisodeImportedEvent -> MissingController 2024-07-31 10:52:29.7|Trace|CustomFormatCalculationService|Using scene name for release title: Cops S30E03 1080p AMZN WEB-DL DD2 0 x264-TrollHD 2024-07-31 10:52:29.7|Trace|EventAggregator|EpisodeImportedEvent <- MissingController 2024-07-31 10:52:29.7|Trace|EventAggregator|EpisodeImportedEvent -> SeriesController 2024-07-31 10:52:29.7|Trace|EventAggregator|EpisodeImportedEvent <- SeriesController 2024-07-31 10:52:29.7|Trace|EventAggregator|EpisodeImportedEvent -> EpisodeController 2024-07-31 10:52:29.7|Trace|CustomFormatCalculationService|Using scene name for release title: Cops S30E03 1080p AMZN WEB-DL DD2 0 x264-TrollHD 2024-07-31 10:52:29.7|Trace|EventAggregator|EpisodeImportedEvent <- EpisodeController 2024-07-31 10:52:29.7|Trace|EventAggregator|EpisodeImportedEvent -> CalendarController 2024-07-31 10:52:29.7|Trace|CustomFormatCalculationService|Using scene name for release title: Cops S30E03 1080p AMZN WEB-DL DD2 0 x264-TrollHD 2024-07-31 10:52:29.7|Trace|EventAggregator|EpisodeImportedEvent <- CalendarController 2024-07-31 10:52:29.7|Debug|DiskScanService|Scanning '/config/plex/TV Shows - Temp/Cops S30E03 1080p AMZN WEB-DL DD2 0 x264-TrollHD/' for video files 2024-07-31 10:52:29.7|Trace|DiskScanService|1 files were found in /config/plex/TV Shows - Temp/Cops S30E03 1080p AMZN WEB-DL DD2 0 x264-TrollHD/ 2024-07-31 10:52:29.7|Debug|DiskScanService|1 video files were found in /config/plex/TV Shows - Temp/Cops S30E03 1080p AMZN WEB-DL DD2 0 x264-TrollHD/ 2024-07-31 10:52:29.7|Debug|Parser|Parsing string 'Cops.S30E03.Surprise.Guest.1080p.Amazon.WEB-DL.DD.2.0.x264-TrollHD.mkv' 2024-07-31 10:52:29.7|Trace|Parser|^(?<title>.+?)(?:(?:[-_\W](?<![()\[!]))+S?(?<season>(?<!\d+)(?:\d{1,2})(?!\d+))(?:[ex]|\W[ex]){1,2}(?<episode>\d{2,3}(?!\d+))(?:(?:\-|[ex]|\W[ex]|_){1,2}(?<episode>\d{2,3}(?!\d+)))*)(?:[-_. ]|$) 2024-07-31 10:52:29.7|Debug|Parser|Episode Parsed. Cops - S30E03 2024-07-31 10:52:29.7|Debug|Parser|Languages parsed: Unknown 2024-07-31 10:52:29.7|Debug|QualityParser|Trying to parse quality for 'Cops.S30E03.Surprise.Guest.1080p.Amazon.WEB-DL.DD.2.0.x264-TrollHD.mkv' 2024-07-31 10:52:29.7|Debug|Parser|Quality parsed: WEBDL-1080p v1 2024-07-31 10:52:29.7|Debug|Parser|Release Group parsed: TrollHD 2024-07-31 10:52:29.7|Debug|VideoFileInfoReader|Getting media info from /config/plex/TV Shows - Temp/Cops S30E03 1080p AMZN WEB-DL DD2 0 x264-TrollHD/Cops.S30E03.Surprise.Guest.1080p.Amazon.WEB-DL.DD.2.0.x264-TrollHD.mkv 2024-07-31 10:52:29.7|Debug|DetectSample|[/config/plex/TV Shows - Temp/Cops S30E03 1080p AMZN WEB-DL DD2 0 x264-TrollHD/Cops.S30E03.Surprise.Guest.1080p.Amazon.WEB-DL.DD.2.0.x264-TrollHD.mkv] does not appear to be a sample. Runtime 00:20:31.1630000 seconds is more than minimum of 300 seconds 2024-07-31 10:52:29.7|Warn|DownloadedEpisodesImportService|Non-sample file detected: [/config/plex/TV Shows - Temp/Cops S30E03 1080p AMZN WEB-DL DD2 0 x264-TrollHD/Cops.S30E03.Surprise.Guest.1080p.Amazon.WEB-DL.DD.2.0.x264-TrollHD.mkv] 2024-07-31 10:52:29.7|Debug|CompletedDownloadService|All episodes were imported for Cops S30E03 1080p AMZN WEB-DL DD2 0 x264-TrollHD 2024-07-31 10:52:29.7|Trace|EventAggregator|Publishing DownloadCompletedEvent 2024-07-31 10:52:29.7|Trace|EventAggregator|DownloadCompletedEvent -> NotificationService 2024-07-31 10:52:29.7|Trace|EventAggregator|DownloadCompletedEvent <- NotificationService 2024-07-31 10:52:29.7|Trace|EventAggregator|DownloadCompletedEvent -> DownloadEventHub 2024-07-31 10:52:29.7|Debug|DownloadEventHub|[Cops S30E03 1080p AMZN WEB-DL DD2 0 x264-TrollHD] Marking download as imported from SABnzbd 2024-07-31 10:52:29.7|Debug|DownloadEventHub|SABnzbd does not support marking items as imported 2024-07-31 10:52:29.7|Trace|EventAggregator|DownloadCompletedEvent <- DownloadEventHub 2024-07-31 10:52:29.7|Trace|EventAggregator|DownloadCompletedEvent -> DownloadHistoryService 2024-07-31 10:52:29.9|Trace|EventAggregator|DownloadCompletedEvent <- DownloadHistoryService 2024-07-31 10:52:29.9|Trace|EventAggregator|Publishing DownloadCanBeRemovedEvent 2024-07-31 10:52:29.9|Trace|EventAggregator|DownloadCanBeRemovedEvent -> DownloadEventHub 2024-07-31 10:52:29.9|Trace|EventAggregator|DownloadCanBeRemovedEvent <- DownloadEventHub 2024-07-31 10:52:29.9|Trace|EventAggregator|Publishing DownloadsProcessedEvent 2024-07-31 10:52:29.9|Trace|EventAggregator|DownloadsProcessedEvent -> DownloadMonitoringService 2024-07-31 10:52:29.9|Trace|EventAggregator|Publishing TrackedDownloadRefreshedEvent 2024-07-31 10:52:29.9|Trace|EventAggregator|TrackedDownloadRefreshedEvent -> QueueService 2024-07-31 10:52:29.9|Trace|EventAggregator|Publishing QueueUpdatedEvent 2024-07-31 10:52:29.9|Trace|EventAggregator|QueueUpdatedEvent -> QueueController 2024-07-31 10:52:29.9|Trace|EventAggregator|QueueUpdatedEvent <- QueueController 2024-07-31 10:52:29.9|Trace|EventAggregator|QueueUpdatedEvent -> QueueDetailsController 2024-07-31 10:52:29.9|Trace|EventAggregator|QueueUpdatedEvent <- QueueDetailsController 2024-07-31 10:52:29.9|Trace|EventAggregator|QueueUpdatedEvent -> QueueStatusController 2024-07-31 10:52:29.9|Trace|EventAggregator|QueueUpdatedEvent <- QueueStatusController 2024-07-31 10:52:29.9|Trace|EventAggregator|TrackedDownloadRefreshedEvent <- QueueService 2024-07-31 10:52:29.9|Trace|EventAggregator|DownloadsProcessedEvent <- DownloadMonitoringService 2024-07-31 10:52:29.9|Trace|CommandQueueManager|Updating command status 2024-07-31 10:52:29.9|Trace|EventAggregator|DownloadsProcessedEvent ~> NotificationService 2024-07-31 10:52:30.0|Trace|EventAggregator|DownloadsProcessedEvent <~ NotificationService 2024-07-31 10:52:30.0|Trace|EventAggregator|Publishing CommandExecutedEvent 2024-07-31 10:52:30.0|Trace|EventAggregator|CommandExecutedEvent -> TaskManager 2024-07-31 10:52:30.0|Trace|EventAggregator|CommandExecutedEvent <- TaskManager 2024-07-31 10:52:30.0|Trace|EventAggregator|CommandExecutedEvent -> TaskController 2024-07-31 10:52:30.0|Trace|EventAggregator|CommandExecutedEvent <- TaskController 2024-07-31 10:52:30.0|Trace|EventAggregator|CommandExecutedEvent -> QualityDefinitionController 2024-07-31 10:52:30.0|Trace|EventAggregator|CommandExecutedEvent <- QualityDefinitionController 2024-07-31 10:52:30.0|Trace|CommandExecutor|ProcessMonitoredDownloadsCommand <- DownloadProcessingService [00:00:02.3912928] 2024-07-31 10:52:30.0|Trace|Http|Req: 7444 [GET] /api/v3/command (from 192.168.1.80 Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:127.0) Gecko/20100101 Firefox/127.0) 2024-07-31 10:52:30.0|Trace|CommandQueueManager|Getting all commands 2024-07-31 10:52:30.0|Trace|Http|Res: 7444 [GET] /api/v3/command: 200.OK (0 ms) 2024-07-31 10:52:30.0|Debug|Api|[GET] /api/v3/command: 200.OK (0 ms) 2024-07-31 10:52:31.2|Trace|Http|Req: 7445 [GET] /api/v3/system/status (from 162.*.*.75 Go-http-client/1.1) 2024-07-31 10:52:31.3|Trace|Http|Res: 7445 [GET] /api/v3/system/status: 200.OK (0 ms) 2024-07-31 10:52:31.3|Debug|Api|[GET] /api/v3/system/status: 200.OK (0 ms) 2024-07-31 10:52:34.6|Trace|CommandQueueManager|Publishing RefreshMonitoredDownloads 2024-07-31 10:52:34.6|Trace|CommandQueueManager|Checking if command is queued or started: RefreshMonitoredDownloads 2024-07-31 10:52:34.6|Trace|CommandQueueManager|Inserting new command: RefreshMonitoredDownloads 2024-07-31 10:52:34.7|Trace|CommandExecutor|RefreshMonitoredDownloadsCommand -> DownloadMonitoringService 2024-07-31 10:52:34.7|Trace|CommandQueueManager|Marking command as started: RefreshMonitoredDownloads 2024-07-31 10:52:34.7|Debug|SabnzbdProxy|Url: http://192.168.1.200:19090/api?mode=queue&start=0&limit=0&category=tv&apikey=(removed)&output=json 2024-07-31 10:52:34.7|Trace|HttpClient|Req: [GET] http://192.168.1.200:19090/api?mode=queue&start=0&limit=0&category=tv&apikey=(removed)&output=json 2024-07-31 10:52:34.7|Trace|ConfigService|Using default config value for 'proxyenabled' defaultValue:'False' 2024-07-31 10:52:34.7|Trace|HttpClient|Res: HTTP/1.1 [GET] http://192.168.1.200:19090/api?mode=queue&start=0&limit=0&category=tv&apikey=(removed)&output=json: 200.OK (600 bytes) (2 ms) 2024-07-31 10:52:34.7|Trace|HttpClient|Response content (600 bytes): {"queue":{"version":"4.3.2","paused":false,"pause_int":"0","paused_all":false,"diskspace1":"2079.03","diskspace2":"2079.03","diskspace1_norm":"2.0 T","diskspace2_norm":"2.0 T","diskspacetotal1":"27265.28","diskspacetotal2":"27265.28","speedlimit":"0","speedlimit_abs":"0","have_warnings":"0","finishaction":null,"quota":"0 ","have_quota":false,"left_quota":"0 ","cache_art":"0","cache_size":"0 B","kbpersec":"0.00","speed":"0 ","mbleft":"0.00","mb":"0.00","sizeleft":"0 B","size":"0 B","noofslots_total":0,"noofslots":0,"start":0,"limit":0,"finish":0,"status":"Idle","timeleft":"0:00:00","slots":[]}} 2024-07-31 10:52:34.7|Trace|ConfigService|Using default config value for 'downloadclienthistorylimit' defaultValue:'60' 2024-07-31 10:52:34.7|Debug|SabnzbdProxy|Url: http://192.168.1.200:19090/api?mode=history&start=0&limit=60&category=tv&apikey=(removed)&output=json 2024-07-31 10:52:34.7|Trace|HttpClient|Req: [GET] http://192.168.1.200:19090/api?mode=history&start=0&limit=60&category=tv&apikey=(removed)&output=json 2024-07-31 10:52:34.7|Trace|ConfigService|Using default config value for 'proxyenabled' defaultValue:'False' 2024-07-31 10:52:34.7|Trace|HttpClient|Res: HTTP/1.1 [GET] http://192.168.1.200:19090/api?mode=history&start=0&limit=60&category=tv&apikey=(removed)&output=json: 200.OK (1566 bytes) (2 ms) 2024-07-31 10:52:34.7|Trace|HttpClient|Response content (1566 bytes): {"history":{"total_size":"10.1 T","month_size":"2.0 T","week_size":"406.1 G","day_size":"180.5 G","slots":[{"completed":1722441105,"name":"Cops S30E03 1080p AMZN WEB-DL DD2 0 x264-TrollHD","nzb_name":"Cops.S30E03.1080p.AMZN.WEB-DL.DD2.0.x264-TrollHD.nzb","category":"tv","pp":"D","script":"None","report":"","url":null,"status":"Completed","nzo_id":"SABnzbd_nzo_sd50c42t","storage":"\/config\/plex\/TV Shows - Temp\/Cops S30E03 1080p AMZN WEB-DL DD2 0 x264-TrollHD\/Cops.S30E03.Surprise.Guest.1080p.Amazon.WEB-DL.DD.2.0.x264-TrollHD.mkv","path":"\/config\/Downloads\/incomplete\/Cops.S30E03.1080p.AMZN.WEB-DL.DD2.0.x264-TrollHD","script_line":"","download_time":25,"postproc_time":18,"stage_log":[{"name":"Source","actions":["Cops.S30E03.1080p.AMZN.WEB-DL.DD2.0.x264-TrollHD.nzb"]},{"name":"Download","actions":["Downloaded in 25 seconds at an average of 86.7 MB\/s<br\/>Age: 2242d"]},{"name":"Servers","actions":["news-us.newshosting.com=2.1 GB"]},{"name":"Repair","actions":["[Cops.S30E03.Surprise.Guest.1080p.Amazon.WEB-DL.DD.2.0.x264-TrollHD] Quick Check OK"]},{"name":"Unpack","actions":["[Cops.S30E03.Surprise.Guest.1080p.Amazon.WEB-DL.DD.2.0.x264-TrollHD] Unpacked 1 files\/folders in 18 seconds"]}],"downloaded":2285604036,"completeness":null,"fail_message":"","url_info":"","bytes":2285604036,"meta":null,"series":null,"md5sum":"af6a838c41da197a520ce66171ea0be5","password":null,"duplicate_key":"cops\/30\/3","archive":false,"size":"2.1 GB","action_line":"","loaded":false,"retry":0}],"ppslots":0,"noofslots":1,"last_history_update":4812,"version":"4.3.2"}} 2024-07-31 10:52:34.7|Trace|EventAggregator|Publishing TrackedDownloadRefreshedEvent 2024-07-31 10:52:34.7|Trace|EventAggregator|TrackedDownloadRefreshedEvent -> QueueService 2024-07-31 10:52:34.7|Trace|EventAggregator|Publishing QueueUpdatedEvent 2024-07-31 10:52:34.7|Trace|EventAggregator|QueueUpdatedEvent -> QueueController 2024-07-31 10:52:34.7|Trace|EventAggregator|QueueUpdatedEvent <- QueueController 2024-07-31 10:52:34.7|Trace|EventAggregator|QueueUpdatedEvent -> QueueDetailsController 2024-07-31 10:52:34.7|Trace|EventAggregator|QueueUpdatedEvent <- QueueDetailsController 2024-07-31 10:52:34.7|Trace|EventAggregator|QueueUpdatedEvent -> QueueStatusController 2024-07-31 10:52:34.7|Trace|EventAggregator|QueueUpdatedEvent <- QueueStatusController 2024-07-31 10:52:34.7|Trace|EventAggregator|TrackedDownloadRefreshedEvent <- QueueService 2024-07-31 10:52:34.7|Trace|CommandQueueManager|Publishing ProcessMonitoredDownloads 2024-07-31 10:52:34.7|Trace|CommandQueueManager|Checking if command is queued or started: ProcessMonitoredDownloads 2024-07-31 10:52:34.7|Trace|CommandQueueManager|Inserting new command: ProcessMonitoredDownloads 2024-07-31 10:52:34.7|Trace|CommandQueueManager|Updating command status 2024-07-31 10:52:34.7|Trace|CommandExecutor|ProcessMonitoredDownloadsCommand -> DownloadProcessingService 2024-07-31 10:52:34.7|Trace|CommandQueueManager|Marking command as started: ProcessMonitoredDownloads 2024-07-31 10:52:34.7|Trace|EventAggregator|Publishing HealthCheckCompleteEvent 2024-07-31 10:52:34.7|Trace|EventAggregator|HealthCheckCompleteEvent -> HealthController 2024-07-31 10:52:34.7|Trace|EventAggregator|HealthCheckCompleteEvent <- HealthController 2024-07-31 10:52:34.7|Trace|EventAggregator|HealthCheckCompleteEvent ~> NotificationService 2024-07-31 10:52:34.7|Trace|EventAggregator|Publishing CommandExecutedEvent 2024-07-31 10:52:34.7|Trace|EventAggregator|CommandExecutedEvent -> TaskManager 2024-07-31 10:52:34.7|Trace|TaskManager|Updating last run time for: NzbDrone.Core.Download.RefreshMonitoredDownloadsCommand 2024-07-31 10:52:34.7|Trace|EventAggregator|HealthCheckCompleteEvent <~ NotificationService 2024-07-31 10:52:34.7|Trace|Http|Req: 7446 [GET] /api/v3/health (from 192.168.1.80 Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:127.0) Gecko/20100101 Firefox/127.0) 2024-07-31 10:52:34.7|Trace|Http|Res: 7446 [GET] /api/v3/health: 200.OK (0 ms) 2024-07-31 10:52:34.7|Debug|Api|[GET] /api/v3/health: 200.OK (0 ms) 2024-07-31 10:52:35.6|Trace|EventAggregator|Publishing DownloadCanBeRemovedEvent 2024-07-31 10:52:35.6|Trace|EventAggregator|DownloadCanBeRemovedEvent -> DownloadEventHub 2024-07-31 10:52:35.6|Trace|EventAggregator|DownloadCanBeRemovedEvent <- DownloadEventHub 2024-07-31 10:52:35.6|Trace|EventAggregator|Publishing DownloadsProcessedEvent 2024-07-31 10:52:35.6|Trace|EventAggregator|DownloadsProcessedEvent -> DownloadMonitoringService 2024-07-31 10:52:35.6|Trace|EventAggregator|Publishing TrackedDownloadRefreshedEvent 2024-07-31 10:52:35.6|Trace|EventAggregator|TrackedDownloadRefreshedEvent -> QueueService 2024-07-31 10:52:35.6|Trace|EventAggregator|Publishing QueueUpdatedEvent 2024-07-31 10:52:35.6|Trace|EventAggregator|QueueUpdatedEvent -> QueueController 2024-07-31 10:52:35.6|Trace|EventAggregator|QueueUpdatedEvent <- QueueController 2024-07-31 10:52:35.6|Trace|EventAggregator|QueueUpdatedEvent -> QueueDetailsController 2024-07-31 10:52:35.6|Trace|EventAggregator|QueueUpdatedEvent <- QueueDetailsController 2024-07-31 10:52:35.6|Trace|EventAggregator|QueueUpdatedEvent -> QueueStatusController 2024-07-31 10:52:35.6|Trace|EventAggregator|QueueUpdatedEvent <- QueueStatusController 2024-07-31 10:52:35.6|Trace|EventAggregator|TrackedDownloadRefreshedEvent <- QueueService 2024-07-31 10:52:35.6|Trace|EventAggregator|DownloadsProcessedEvent <- DownloadMonitoringService 2024-07-31 10:52:35.6|Trace|CommandQueueManager|Updating command status 2024-07-31 10:52:35.6|Trace|EventAggregator|DownloadsProcessedEvent ~> NotificationService 2024-07-31 10:52:35.6|Trace|EventAggregator|DownloadsProcessedEvent <~ NotificationService 2024-07-31 10:52:36.5|Trace|EventAggregator|CommandExecutedEvent <- TaskManager 2024-07-31 10:52:36.5|Trace|EventAggregator|CommandExecutedEvent -> TaskController 2024-07-31 10:52:36.5|Trace|EventAggregator|CommandExecutedEvent <- TaskController 2024-07-31 10:52:36.5|Trace|EventAggregator|CommandExecutedEvent -> QualityDefinitionController 2024-07-31 10:52:36.5|Trace|EventAggregator|CommandExecutedEvent <- QualityDefinitionController 2024-07-31 10:52:36.5|Trace|CommandExecutor|RefreshMonitoredDownloadsCommand <- DownloadMonitoringService [00:00:00.0372589] 2024-07-31 10:52:36.5|Trace|Http|Req: 7447 [GET] /api/v3/command (from 192.168.1.80 Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:127.0) Gecko/20100101 Firefox/127.0) 2024-07-31 10:52:36.5|Trace|CommandQueueManager|Getting all commands 2024-07-31 10:52:36.5|Trace|Http|Res: 7447 [GET] /api/v3/command: 200.OK (0 ms) 2024-07-31 10:52:36.5|Debug|Api|[GET] /api/v3/command: 200.OK (0 ms) 2024-07-31 10:52:37.0|Trace|EventAggregator|Publishing CommandExecutedEvent 2024-07-31 10:52:37.0|Trace|EventAggregator|CommandExecutedEvent -> TaskManager 2024-07-31 10:52:37.0|Trace|EventAggregator|CommandExecutedEvent <- TaskManager 2024-07-31 10:52:37.0|Trace|EventAggregator|CommandExecutedEvent -> TaskController 2024-07-31 10:52:37.0|Trace|EventAggregator|CommandExecutedEvent <- TaskController 2024-07-31 10:52:37.0|Trace|EventAggregator|CommandExecutedEvent -> QualityDefinitionController 2024-07-31 10:52:37.0|Trace|EventAggregator|CommandExecutedEvent <- QualityDefinitionController 2024-07-31 10:52:37.0|Trace|CommandExecutor|ProcessMonitoredDownloadsCommand <- DownloadProcessingService [00:00:00.9146832] 2024-07-31 10:52:37.0|Trace|Http|Req: 7448 [GET] /api/v3/command (from 192.168.1.80 Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:127.0) Gecko/20100101 Firefox/127.0) 2024-07-31 10:52:37.0|Trace|CommandQueueManager|Getting all commands 2024-07-31 10:52:37.0|Trace|Http|Res: 7448 [GET] /api/v3/command: 200.OK (1 ms) 2024-07-31 10:52:37.0|Debug|Api|[GET] /api/v3/command: 200.OK (1 ms) 2024-07-31 10:52:51.1|Trace|Http|Req: 7449 [GET] /logfile/sonarr.trace.txt (from 192.168.1.80 Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:127.0) Gecko/20100101 Firefox/127.0) 2024-07-31 10:52:51.1|Trace|Http|Res: 7449 [GET] /logfile/sonarr.trace.txt: 200.OK (24 ms) 2024-07-31 10:52:57.1|Trace|Scheduler|Pending Tasks: 0 2024-07-31 10:53:14.5|Trace|Http|Req: 7450 [GET] /api/v3/log/file (from 192.168.1.80 Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:127.0) Gecko/20100101 Firefox/127.0) 2024-07-31 10:53:14.5|Trace|Http|Res: 7450 [GET] /api/v3/log/file: 200.OK (20 ms) 2024-07-31 10:53:14.5|Debug|Api|[GET] /api/v3/log/file: 200.OK (20 ms) 2024-07-31 10:53:15.8|Trace|Http|Req: 7451 [GET] /logfile/sonarr.trace.txt (from 192.168.1.80 Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:127.0) Gecko/20100101 Firefox/127.0)

Anything else?

No response

markus101 commented 1 month ago

@mynameisbogdan I didn't consider this part of it, we should absolutely move for usenet still. Making more sense to do it per client and potentially clean up have CanMoveFiles / CanBeRemoved

gold007eye commented 1 month ago

@markus101 That sounds great! I like that idea so usenet clients can chose and your idea makes sense for torrent clients. Are we able to rollback the new code or would it be a code update to allow for per client decision and always allow move for usenet by default?

mynameisbogdan commented 1 month ago

I didn't consider this part of it, we should absolutely move for usenet still. Making more sense to do it per client and potentially clean up have CanMoveFiles / CanBeRemoved

diff --git a/src/NzbDrone.Core/Download/DownloadClientItem.cs b/src/NzbDrone.Core/Download/DownloadClientItem.cs
index 76ed0cb2ce..101bef4a74 100644
--- a/src/NzbDrone.Core/Download/DownloadClientItem.cs
+++ b/src/NzbDrone.Core/Download/DownloadClientItem.cs
@@ -50,7 +50,7 @@ public static DownloadClientItemClientInfo FromDownloadClient<TSettings>(
                 Type = downloadClient.Name,
                 Id = downloadClient.Definition.Id,
                 Name = downloadClient.Definition.Name,
-                RemoveCompletedDownloads = downloadClient.Definition is DownloadClientDefinition { RemoveCompletedDownloads: true },
+                RemoveCompletedDownloads = downloadClient.Definition is DownloadClientDefinition { RemoveCompletedDownloads: true } or DownloadClientDefinition { Protocol: DownloadProtocol.Usenet },
                 HasPostImportCategory = hasPostImportCategory
             };
         }

Was thinking off about adding an exception for usenet, but I guess I can't get rid of editing every download client implementation. 😭