search

Sonerezh / sonerezh

A self-hosted, web-based application to stream your music, everywhere.
https://www.sonerezh.bzh
GNU Affero General Public License v3.0
767 stars 122 forks source link

Do not convert tags to HTML #361

Closed Nizhile closed 5 years ago

Nizhile commented 5 years ago

By default, getID3 creates HTML version for all tags. In particular, it will convert the picture tag (which could be a bug). Depending on cover arts included in audio files, this feature triggers #354.

lGuillaume124 commented 5 years ago

Could you complete the changelog and add a "Fixed" subtitle under the "Unreleased" section please?

Thank you for your contribution, I will try and merge it as soon as I can.

lGuillaume124 commented 5 years ago

Awesome! One line changed and the parsing is more than ten times faster! Nice catch, thank you very much!

Without the patch:

$ time ./cake sonerezh sync --import --force
[...]
[INFO   ] Imported: 48 file(s).
./cake sonerezh sync --import --force  12,54s user 0,59s system 91% cpu 14,411 total

With the patch:

$ time ./cake sonerezh sync --import --force
[...]
[INFO   ] Imported: 48 file(s).
./cake sonerezh sync --import --force  0,72s user 0,36s system 65% cpu 1,655 total