Fix #294: Better mobile experience

Sonerezh / sonerezh

A self-hosted, web-based application to stream your music, everywhere.

https://www.sonerezh.bzh

GNU Affero General Public License v3.0

767 stars 122 forks source link

Fix #294: Better mobile experience #367

Open skw4y opened 5 years ago

skw4y commented 5 years ago

Some Sonerezh theme hacks for a better mobile experience :

Navbar player on Bottom
Next/Previous icon modification
More space for the playing controls (play/next/previous)
Navbar collapse fix
Some controls are hidden on XS screens

Desktop Preview

desktop

Mobile Preview

mobile

MightyCreak commented 5 years ago

That's promising! Could you add some screenshots for both web and mobile, please?

skw4y commented 5 years ago

I've made some changes since the creation of the repository but you can preview some screenshots there: https://github.com/skw4y/sonerezh-mobile

I didn't find the existing screenshots of the project but sure I can add some.

MightyCreak commented 5 years ago

@lGuillaume124 For me it seems all good. I actually prefer the player on the bottom since it follows the industry standard and definitely makes more sense on mobile.

@skw4y From the mobile screenshot, I don't see these buttons:

Is it possible to access them somehow, or they're completely hidden when on mobile?

skw4y commented 5 years ago

@MightyCreak On mobile the shuffle button is visible but the other two are completely hidden for the moment: sonerezh_mobile

MightyCreak commented 5 years ago

The screenshots on your changes seem a bit outdated (for instance the play controls are now on the bottom right, it is on the bottom left in your screenshots). Could you just refresh the ones from your changes? The interface here on master didn't change that much (though a discussion is in progress).

skw4y commented 5 years ago

Yes sure, I was pointing the one in my repository just to give you an idea but I'll refresh them tonight.

MightyCreak commented 5 years ago

Thank you! Much appreciated :wink:

skw4y commented 5 years ago

I've just updated the screenshots on my sonerezh-mobile repo but I can also add them to the current pull request if you want.

MightyCreak commented 5 years ago

Thanks!

If you could add them in the PR description, that would be awesome (the more descriptive a PR is, the more probable it will be merged, because it's easier to get in and review since we know what to expect).

But the final word will be for @lGuillaume124 anyway 😉