Closed Dahie closed 4 years ago
In the original regex, a lyrics part would be split by special characters like ä, ö, ü. The old regex was whitelisting characters that are in a piece of lyrics. The new regex is blacklisting when a piece of lyrics should be split: on the chords.
Rspec tests are all green.
Hey @Dahie. I'm only just seeing these PRs today. (Not sure why I didn't any kind of notification?) I'll be taking a look at them soon. Thanks!
@Dahie Thanks for this!
I thank you :)
In the original regex, a lyrics part would be split by special characters like ä, ö, ü. The old regex was whitelisting characters that are in a piece of lyrics. The new regex is blacklisting when a piece of lyrics should be split: on the chords.
Rspec tests are all green.