adds support of special characters and respective tests

SongProOrg / songpro-ruby

A Ruby Gem to convert SongPro songs to a Ruby object used to generate various output formats.

https://songpro.org

MIT License

5 stars 1 forks source link

adds support of special characters and respective tests #1

Closed Dahie closed 4 years ago

Dahie commented 4 years ago

In the original regex, a lyrics part would be split by special characters like ä, ö, ü. The old regex was whitelisting characters that are in a piece of lyrics. The new regex is blacklisting when a piece of lyrics should be split: on the chords.

Rspec tests are all green.

spilth commented 4 years ago

Hey @Dahie. I'm only just seeing these PRs today. (Not sure why I didn't any kind of notification?) I'll be taking a look at them soon. Thanks!

spilth commented 4 years ago

@Dahie Thanks for this!

Dahie commented 4 years ago

I thank you :)