Lyric parts' leading and trailing whitespaces are not trimmed anymore - Githubissues

SongProOrg / songpro-ruby

A Ruby Gem to convert SongPro songs to a Ruby object used to generate various output formats.

https://songpro.org

MIT License

5 stars 1 forks source link

Lyric parts' leading and trailing whitespaces are not trimmed anymore #3

Closed Dahie closed 4 years ago

Dahie commented 4 years ago

This is the code discussed in https://github.com/SongProOrg/songpro-ruby/issues/2

Most changes are actually to the existing expectations. As mentioned in the Issue, I don't know if the old behaviour was intentional, of if this change causes side effects with existing uses.

spilth commented 4 years ago

Hey @Dahie. I pulled in your branch, installed the gem locally and tried my site with it and all seems to be well. So I'm gonna merge this in. If there ends up being a problem we can always revert the change.

I'm also gonna update the Ruby version, update any dependencies that need it and push out a new version.