Open SongZijin opened 1 year ago
The red cross representing the deletion in :PackCommand
(in the second image) is missing, there is no grounds for this being a medium level severity and should be very low as it is a typo which does not affect the readers understanding of the diagrams.
Team chose [severity.VeryLow
]
Originally [severity.Medium
]
Reason for disagreement: I agree with the fact that it should not be Medium, however, I think this should have a severity of Low, since VeryLow is only for cosmetic components like formatting, while the inconsistency in the diagrams may confuse the reader in understanding if the command object is deleted or not and how the first diagram relates to the others.
In the first sequence diagram (for runBagPacker() Mechanism), the command object is shown to be deleted after it is done executing, as shown below: However, this is not the case for sequence diagrams of the specific diagrams that are found in later parts of the developer guide.