search

SonicTHI / SaveOurShip2Experimental

Experimental branch of Save Our Ship 2
Other
231 stars 85 forks source link

Fixed pawns not auto-refueling ship reactors to full target capacity #114

Closed CyberSavvy531 closed 9 months ago

CyberSavvy531 commented 9 months ago

I know this bug has been around for a while (it makes my OCD violently ill), and I noticed pawns would always stop fueling the reactor at roughly 1/3 of target capacity. After some digging I found that CompProperties_Refuelable has a variable autoRefuelPercent set to 0.3f or 30%. Ship engines and the hullfoam distributor actually already have this tag in their defs set to 1, so this appears to have just been an oversight for the reactors.

I chose 0.95 so pawns aren't constantly refilling the reactor after a single unit of fuel is consumed. Also added decimal points to their fuel values for consistency.

SonicTHI commented 9 months ago

https://github.com/SonicTHI/SaveOurShip2Experimental#contribution--code-submissions--pull-requests--mod-conflict-resolutions

It is nice that you found the issue but the rest of the edits are unnecessary. I ll change it to .9 for all refuelables with next patch..