SonicTHI / SaveOurShip2Experimental

Experimental branch of Save Our Ship 2
Other
230 stars 86 forks source link

Incompatible with Elite Bionics Framework #181

Closed Vectorial1024 closed 2 months ago

Vectorial1024 commented 3 months ago

Ref https://github.com/Vectorial1024/EliteBionicsFramework/issues/3 ; by reading the source code of SOS2, I can see HediffPawnIsHologram is using GetMaxHealth, which is deprecated when using Elite Bionics Framework.

Normally EBF will make a patch on their side and close the issue, but this time because HediffPawnIsHologram is internal, EBF cannot make patches. Is the internal status intentional?

Would the SOS2 team consider one of the following?

Many thanks!

Vectorial1024 commented 2 months ago

Ref the latest SOS2 situation, I must admit: when I was writing about this, I got into this repo from a web search. I knew only a bit about how SOS2 has entered a very long experimental phase, but did not know any further details. And very importantly I wrongly thought I was writing to the official repo.

But anyway, given the developing situation, I understand EXP cannot respond to this question since there is a dispute. I will just observe the situation for now.