SonixQMK / qmk_firmware

Open-source keyboard firmware for Atmel AVR and Arm USB families
https://sonixqmk.github.io/qmk_docs/
GNU General Public License v2.0
523 stars 412 forks source link

[SPCGear GK630K] Initial keyboard bringup #207

Closed tfuxu closed 1 year ago

tfuxu commented 2 years ago

Description

This PR adds basic support for SPCGear GK630K. VIA support isn't available for now, because I had some issues with RGB matrix after flashing, I'll investigate this later. After recent updates, VIA is working properly.

I took as a base Redragon K552-2 code, with small inspirations from Keychron C1 RGB and added some improvements.

The only problem I've noticed with firmware is that the RGB matrix possibly has a different refresh rate than it should normally have, but from what I've seen this is known issue in SonixQMK branch.

Types of Changes

Issues Fixed or Closed by This PR

Checklist

ppkt commented 2 years ago

@tfuxu I just checked your branch and I noticed that there is something wrong with RGB matrix for keys: Space, Right Alt, Fn and Right Ctrl - for these keys LEDs are on for 100% of time. Also Menu button seems to be in incorrect place in matrix. I updated my branch as well so you can compare them.

tfuxu commented 2 years ago

@ppkt When do these problems occur? As for the keys LEDs always being on in the 6th row, they were misaligned in my old branch spcgear_gk630k, and has been fixed in the current branch that I'm using for this PR. Menu button was a victim of these misaligned keys and was then accidentally aligned to spacebar position.

The possibilities are that either you compiled my old branch, or SPCGear maybe released a different revision of the same keyboard with different matrix wiring.

ppkt commented 2 years ago

@tfuxu ohh, you're right - by accident I used your old branch (spcgear_630k). I just checked spcgear_gk630k_master and everything is working fine :)

tfuxu commented 2 years ago

@ppkt Good to know that everything's working fine, and thanks for feedback

Muraske commented 2 years ago

@tfuxu Thanks for your godly work! Was just searching for this. Is VIA working for you? I compiled from master and then from updated branch (obviously with via keymap) for gk630k and cannot seem to get it to work. Trying with either webapp from caniusevia or VIA installed on windows to no avail. Could you help me out with sorting this?

tfuxu commented 2 years ago

I haven't used VIA since I've moved to Linux, but I can check it for you tomorrow.

Muraske commented 2 years ago

I would be grateful :)

tfuxu commented 2 years ago

@Muraske You probably didn't manually load a JSON file in VIA. You can do this by toggling the Show Design tab setting in Settings tab. In Design tab you need to load a draft definition, this will be for you a gk630k.json file, which is located in a root directory of this keyboard. After that, you should be ready to go :) As a sidenote, I would recommend you to use Vial instead of VIA, because it takes less computer resources, and it's easier to load a JSON file from it.

Muraske commented 2 years ago

Thank you! I will try this as soon as I get back home :) Thank you for the tips!