introduce support for Royal Kludge RK61 non-hotswap rgb edition (PID 0x24F)

SonixQMK / qmk_firmware

Open-source keyboard firmware for Atmel AVR and Arm USB families

https://qmk.fm

GNU General Public License v2.0

515 stars 409 forks source link

introduce support for Royal Kludge RK61 non-hotswap rgb edition (PID 0x24F) #252

Closed mr-july closed 1 year ago

mr-july commented 2 years ago

This is improved version of euwbah (see https://github.com/euwbah/qmk_firmware/tree/sn32/keyboards/royal_kludge/rk61_rgb):

better organized directory structure
add support for ISO layout
implement a keymap, which supports Neo Layout (https://www.neo-layout.org/) layers 3 and 4

Description

Types of Changes

[X] Keyboard (addition or update)
[X] Keymap/layout/userspace (addition or update)

Checklist

[X] My code follows the code style of this project: C, Python
[X] I have read the PR Checklist document and have made the appropriate changes.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[X] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[X] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

mr-july commented 2 years ago

I can't reproduce this compiling issue. But i could find some tips on reddit, which hopefully can help.

vjdato21 commented 2 years ago

I can't reproduce this compiling issue. But i could find some tips on reddit, which hopefully can help.

Hmm... What are you using when you're compiling the firmware?

mr-july commented 2 years ago

I have installed the Arch Linux qmk package and compile the keymap by running

qmk compile -k royal_kludge/rk61/rgb -m default

something like this...

vjdato21 commented 2 years ago

I have installed the Arch Linux qmk package and compile the keymap by running sh qmk compile -k royal_kludge/rk61/rgb -m default something like this... … On 28 March 2022 15:14:36 vjdato21 @.***> wrote: I can't reproduce this compiling issue. But i could find some tips on reddit, which hopefully can help. Hmm... What are you using when you're compiling the firmware? — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

Hmm... I'm using QMK MSYS and I've tried make and qmk compile, seems like both don't work on my end. I'll try using it in another operating system once I get some time.

mr-july commented 2 years ago

Sorry, it was really a problem with ´keymap.h´ (this name seems to conflict with the system one), so I have renamed the file to ´layout.h´. Now your compile problem should be fixed.

vjdato21 commented 2 years ago

Sorry, it was really a problem with ´keymap.h´ (this name seems to conflict with the system one), so I have renamed the file to ´layout.h´. Now your compile problem should be fixed.

Yep, it compiled now. It's kinda weird that yours doesn't complain about it.

vjdato21 commented 2 years ago

I'm looking right now for a plate file for RK61. This will be useful for making the .json file for VIA, if ever you do find one, that'll be helpful.

vjdato21 commented 2 years ago

I'm looking right now for a plate file for RK61. This will be useful for making the .json file for VIA, if ever you do find one, that'll be helpful.

Update: Seems to be using a standard layout. Keycaps sizes should be easily sorted out now. I'll try make a .json file later.

rnayabed commented 1 year ago

any updates?

github-actions[bot] commented 1 year ago

Thank you for your contribution! This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready. For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

github-actions[bot] commented 1 year ago

Thank you for your contribution! This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. // [stale-action-closed]