Closed FabianMaurerMathema closed 2 years ago
This shouldn't be needed because OpenRGB sends SET_MODE with RGB_MATRIX_OPENRGB_DIRECT when Direct mode is enabled.
If direct mode is broken then it's either because of openrgb_get_enabled_modes returning wrong values (fixed by #284) or config.h having QMK effects enabled that OpenRGB doesn't support (ENABLE_RGB_MATRIX_PIXEL_RAIN, ENABLE_RGB_MATRIX_PIXEL_FRACTAL).
Yes, seems we had both of these issues, ENABLE_RGB_MATRIX_PIXEL_RAIN and the issue fixed by #284. Thanks for the update, this can be closed!
When using OpenRGB to set direct mode LEDs, also set the internal state of the firmware to direct mode.
@Kasper24 Since you made the original code, would you mind checking if that is correct?
Description
This is needed, because otherwise the firmware will keep the current operating mode. Without this fix applied, direct mode is not working at all for us.
Types of Changes
Issues Fixed or Closed by This PR
Checklist