Update config_led.c - Githubissues

SonixQMK / qmk_firmware

Open-source keyboard firmware for Atmel AVR and Arm USB families

https://qmk.fm

GNU General Public License v2.0

515 stars 409 forks source link

Update config_led.c #265

Closed l33tlinuxh4x0r closed 1 year ago

l33tlinuxh4x0r commented 2 years ago

Description

I updated config_led.c to reflect the keyboards 104 keys instead of 106 Everything works the same RGB is functioning the same as well. I have tested on 2 keyboards and it looks good here.

Types of Changes

[ ] Core
[ ] Bugfix
[ ] New feature
[ ] Enhancement/optimization
[ ] Keyboard (addition or update)
[ ] Keymap/layout/userspace (addition or update)
[ ] Documentation

Issues Fixed or Closed by This PR

Checklist

[ ] My code follows the code style of this project: C, Python
[ ] I have read the PR Checklist document and have made the appropriate changes.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

dexter93 commented 1 year ago

This will bring up issues with ISO k556. The keyboard tree/configs probably have to be split there to ISO/ANSI avoid that

github-actions[bot] commented 1 year ago

Thank you for your contribution! This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready. For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

github-actions[bot] commented 1 year ago

Thank you for your contribution! This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. // [stale-action-closed]