openrgb: Fix response of GET_ENABLED_MODES command - Githubissues

SonixQMK / qmk_firmware

Open-source keyboard firmware for Atmel AVR and Arm USB families

https://qmk.fm

GNU General Public License v2.0

515 stars 409 forks source link

openrgb: Fix response of GET_ENABLED_MODES command #284

Closed ghost closed 1 year ago

ghost commented 2 years ago

Description

openrgb_rgb_matrix_effects_indexes was missing the first OpenRGB effect mode, direct mode.

This PR adds direct mode to the array and corrects the indices of the other effects so they match the enum defined at https://gitlab.com/CalcProgrammer1/OpenRGB/-/blob/master/Controllers/QMKOpenRGBController/QMKOpenRGBController.h#L37

This fixes issues with OpenRGB not showing the last supported effect and setting wrong effect mode when Direct mode is selected.

Types of Changes

[ ] Core
[x] Bugfix
[ ] New feature
[ ] Enhancement/optimization
[ ] Keyboard (addition or update)
[ ] Keymap/layout/userspace (addition or update)
[ ] Documentation

Checklist

[x] My code follows the code style of this project: C, Python
[x] I have read the PR Checklist document and have made the appropriate changes.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] I have tested the changes and verified that they work and don't break anything (as well as I can manage).