Add k8 (rgb) converted to info.json style

SonixQMK / qmk_firmware

Open-source keyboard firmware for Atmel AVR and Arm USB families

https://qmk.fm

GNU General Public License v2.0

515 stars 409 forks source link

Add k8 (rgb) converted to info.json style #291

Closed tbowmo closed 1 year ago

tbowmo commented 1 year ago

Description

Types of Changes

[ ] Core
[ ] Bugfix
[ ] New feature
[ ] Enhancement/optimization
[X] Keyboard (addition or update)
[ ] Keymap/layout/userspace (addition or update)
[ ] Documentation

Issues Fixed or Closed by This PR

Checklist

[ ] My code follows the code style of this project: C, Python
[ ] I have read the PR Checklist document and have made the appropriate changes.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

tbowmo commented 1 year ago

Tested with K8 rgb ISO variant.

All other variants is verified by a small python test routine comparing the autogenerated mapping macro, with the one in the original header files (from old master)

davecarrijo commented 1 year ago

Is via working?

tbowmo commented 1 year ago

Should be, but haven't tested yet. I only did a quick test of plain iso layout, which worked as expected.

davecarrijo commented 1 year ago

I have the k8 ansi variant, if you need a tester I will gladly help

tbowmo commented 1 year ago

Via is now verified as working (iso variant). Also updated default via keymap to be the same as windows iso layout.

davecarrijo commented 1 year ago

so... with this we can use VIA now?

tbowmo commented 1 year ago

@davecarrijo seems that via is temporarily broken in this PR (it worked initially, but a lot has changed since then)

davecarrijo commented 1 year ago

@davecarrijo seems that via is temporarily broken in this PR (it worked initially, but a lot has changed since then)

Did you changed the pid and the vid? What it changes?

tbowmo commented 1 year ago

I changed pid to the correct one for the iso variants, which also happens to fix via support :)

vware commented 1 year ago

this is looking quite nice actually, and it is the basis for the bluetooth pr, any chance this will get merged soonish? ;)

davecarrijo commented 1 year ago

I changed pid to the correct one for the iso variants, which also happens to fix via support :)

The man !!!🫡

davecarrijo commented 1 year ago

this is looking quite nice actually, and it is the basis for the bluetooth pr, any chance this will get merged soonish? ;)

That would made it just one of the best keyboards out there.