SonixQMK / qmk_firmware

Open-source keyboard firmware for Atmel AVR and Arm USB families
https://qmk.fm
GNU General Public License v2.0
506 stars 399 forks source link

sn32 keyboards: migrate rgb animations to data driven #340

Closed dexter93 closed 1 year ago

dexter93 commented 1 year ago

also fix build

Description

Types of Changes

Issues Fixed or Closed by This PR

Checklist

dexter93 commented 1 year ago

tagging maintainers to review before merge

Thank you in advance guys :+1:

elpekenin commented 1 year ago

Relized just now that ozone/tactical could/should have more effects enabled, to be closer to the firmware that was shipped with it... Anyway, changes look good to me (not tested as kb is lost somewhere in a closet lol)

Vesek commented 1 year ago

I'll try to compile this and send the results

Vesek commented 1 year ago

It does work but some of the animations are probably missing, that is causing a misalignment in the menu in VIA.

dexter93 commented 1 year ago

fixed the naming. apprently this is how they get generated

and these are the effects VIA supports

              'All Off',
              'Solid Color',

are enabled by default.

Full list following for reference, rgb_matrix animations currently supported in latest sn32_develop

    "rgb_matrix": {
        "animations": {
            "alphas_mods" : true,
            "band_pinwheel_sat" : true,
            "band_pinwheel_val" : true,
            "band_sat" : true,
            "band_spiral_sat" : true,
            "band_spiral_val" : true,
            "band_val" : true,
            "breathing" : true,
            "cycle_all" : true,
            "cycle_left_right" : true,
            "cycle_out_in" : true,
            "cycle_out_in_dual" : true,
            "cycle_pinwheel" : true,
            "cycle_spiral" : true,
            "cycle_up_down" : true,
            "digital_rain" : true,
            "dual_beacon" : true,
            "gradient_left_right" : true,
            "gradient_up_down" : true,
            "hue_breathing" : true,
            "hue_pendulum" : true,
            "hue_wave" : true,
            "jellybean_raindrops" : true,
            "multisplash" : true,
            "pixel_flow" : true,
            "pixel_fractal" : true,
            "pixel_rain" : true,
            "rainbow_beacon" : true,
            "rainbow_moving_chevron" : true,
            "rainbow_pinwheels" : true,
            "raindrops" : true,
            "solid_multisplash" : true,
            "solid_reactive" : true,
            "solid_reactive_cross" : true,
            "solid_reactive_multicross" : true,
            "solid_reactive_multinexus" : true,
            "solid_reactive_multiwide" : true,
            "solid_reactive_nexus" : true,
            "solid_reactive_simple" : true,
            "solid_reactive_wide" : true,
            "solid_splash" : true,
            "splash" : true,
            "typing_heatmap" : true,
        },
}
Vesek commented 1 year ago

Tried again, everything works as expected.