SonixQMK / qmk_firmware

Open-source keyboard firmware for Atmel AVR and Arm USB families
https://qmk.fm
GNU General Public License v2.0
506 stars 399 forks source link

Get bootmagic working with shared sn32f24xb matrix #356

Closed karliss closed 7 months ago

karliss commented 10 months ago

Description

Fix bootmagic lite when using sn32f24xb shared rgb/key matrix driver.

Bootmagic lite gets checked as early as possible -> after key matrix has been initialized but before other optional subystems like RGB are running. Even if bootmagic check happened after rgb is initialized the actual scanning code runs at it's own pace based on timer interrupts, which makes it's usage during early init somewhat problematic. As a result bootmagic_lite doesn't work probably for most sonix keyboards using shared matrix and the corresponding driver.

This PR adds single manual key only scan to ensure there is meaningful data when the default bootmagic implementation reads it.

Types of Changes

Checklist

karliss commented 10 months ago

Currently keeping as draft as I want to test it compiles with all the relevant sonix boards currently in sn32_develop.

karliss commented 10 months ago

Tested:

github-actions[bot] commented 8 months ago

Thank you for your contribution! This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready. For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

github-actions[bot] commented 7 months ago

Thank you for your contribution! This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. // [stale-action-closed]