SonixQMK / qmk_firmware

Open-source keyboard firmware for Atmel AVR and Arm USB families
https://qmk.fm
GNU General Public License v2.0
506 stars 399 forks source link

sn32 rgb: yet another major update - more modularity #369

Open dexter93 opened 7 months ago

dexter93 commented 7 months ago

Description

Types of Changes

Issues Fixed or Closed by This PR

Checklist

fightforlife commented 7 months ago

Working good for me on 268F with ROW2COL. But I had two things to change to make it perfect. Maybe a second board/user would be good to make sure these are no issues on my side/config.

Here I need to use current_key_col vs last_key_col, otherwise the keypress effects are lit one to the left. https://github.com/SonixQMK/qmk_firmware/blob/e3f4c6d48efb4c44aaab522752a6aec3531dfebf/drivers/led/sn32f2xx.c#L518-L522

This is also needed for HARDWARE_PWM. If not included, columns which have not the max amount of keys(rows) will light the last key all the time. https://github.com/SonixQMK/qmk_firmware/blob/e3f4c6d48efb4c44aaab522752a6aec3531dfebf/drivers/led/sn32f2xx.c#L389-L391 https://github.com/SonixQMK/qmk_firmware/blob/e3f4c6d48efb4c44aaab522752a6aec3531dfebf/drivers/led/sn32f2xx.c#L502-L504