SonixQMK / qmk_firmware

Open-source keyboard firmware for Atmel AVR and Arm USB families
https://qmk.fm
GNU General Public License v2.0
515 stars 409 forks source link

Resurrect Keychron K12 #393

Closed turai closed 1 month ago

turai commented 1 month ago

Description

Nothing special, just ported k12 from the old branch.

Types of Changes

Checklist

turai commented 1 month ago

I saw in mainline they consider all non-character keys as modifiers. It doesn't make much sense to me, but the flags were changed accordingly.

For example if you search repo:qmk/qmk_firmware rgb_matrix lang:json these come up: https://github.com/qmk/qmk_firmware/blob/5acc3b2b7b13e6057623091a4bced7b1d9e76cdb/keyboards/keychron/q2/iso/keyboard.json#L8

dexter93 commented 1 month ago

I saw in mainline they consider all non-character keys as modifiers. It doesn't make much sense to me, but the flags were changed accordingly.

For example if you search repo:qmk/qmk_firmware rgb_matrix lang:json these come up: https://github.com/qmk/qmk_firmware/blob/5acc3b2b7b13e6057623091a4bced7b1d9e76cdb/keyboards/keychron/q2/iso/keyboard.json#L8

that's correct. You can see the result on Alpha Mods RGB animation