search

SonnenladenGmbH / APsystems-EZ1-API

The APsystems EZ1 Python library offers a streamlined interface for interacting with the local API of APsystems EZ1 Microinverters.
MIT License
54 stars 7 forks source link

Add unit tests #7

Closed CM000n closed 6 months ago

CM000n commented 6 months ago

Proposal for adding unit tests

mawoka-myblock commented 6 months ago

Why did you close this PR? Because there's no way to have a reliable Inverter available, right?

CM000n commented 6 months ago

Why did you close this PR? Because there's no way to have a reliable Inverter available, right?

No, I have closed it for the time being because it looks a bit confusing, as all the changes from the refactoring PR are also displayed. I will open it again when the refactoring PR has been merged.

mawoka-myblock commented 6 months ago

Sure!

CM000n commented 6 months ago

I have opened it again. Please note that some of the changes come from PR https://github.com/SonnenladenGmbH/APsystems-EZ1-API/pull/6, that should be merged first.

CM000n commented 6 months ago

Every "raw" response from the inverter is built like the following:

{
  "data": "DATA",
  "status": 0
}

If you want, you can add this, since I've never experienced this status being different from 0.

Hello, please comment on explicit code line numbers. Such a detached comment makes it somewhat difficult to understand exactly what you mean and where.

mawoka-myblock commented 6 months ago

Thanks man! I thought I'd fix these small thinks myself to not annoy you even further! Thank you so much for your work and welcome to 2024 ;) ❤️