search

Sonohi / monster

MONSTeR is a framework built around the LTE system toolbox available in Matlab
MIT License
23 stars 9 forks source link

Merged matrix functionalities into computePathLoss #93

Closed MonsterMarkus closed 5 years ago

jakthra commented 5 years ago

We're really constrained by using the objects of Station and Users in the fingerprints. It severely limits how much we can make the code scalable and easy to use. I think we might need to wrap computeLinkBudget and computePathLoss with a function that extracts the necessary information from the objects/or grid. The only problem with this is that the API just get's way more nested. Do you have any ideas?

jakthra commented 5 years ago

I have refactorized the way the link budget is calculated. Now a temporary struct of distances is constructed when calling the link budget calculation. This extracts the necessary information from the Station object, the user object, and if a grid is given as positions. Path loss calc, and LOS prop calc have been refactorized to better support both scalar computation and array computation.

jakthra commented 5 years ago

@MonsterMarkus @artuso0matteo I could use your review on the code.

MonsterMarkus commented 5 years ago

Found that NLOS and LOS as LOS methods would not return a grid, if a grid was used. Otherwise no comments. Everything looks good.

jakthra commented 5 years ago

Can you add a Github review so we can merge this? Otherwise I'm not getting a green button to click 😢