search

SonyWWS / ATF

Authoring Tools Framework (ATF) is a set of C#/.NET components for making tools on Windows. ATF has been in continuous development in Sony Computer Entertainment's (SCE) Worldwide Studios central tools group since early 2005. ATF has been used by most SCE first party studios to make many custom tools such as Naughty Dog’s level editor and shader editor for The Last of Us, Guerrilla Games’ sequence editor for Killzone games (including the Killzone: Shadow Fall PS4 launch title), an animation blending tool at Santa Monica Studio, a level editor at Bend Studio, a visual state machine editor for Quantic Dream, sound editing tools, and many others.
Apache License 2.0
1.89k stars 262 forks source link

Sub groups #40

Closed twainj closed 9 years ago

twainj commented 9 years ago

I added the new tests to verify the change to a new unit test class, as that seemed to be the best place for them.

twainj commented 9 years ago

@Ron2 Here's the pull request we talked about. Let me know if you see changes that need to happen.

Ron2 commented 9 years ago

Thank you very much, Jason. That was a lot of work on your part and the unit tests were well-written. I reviewed the changes and they look good but then when I ran the full test suite, another unit test failed -- ModifyChildDocumentExternally in TimelineEditorTests. I'm looking into what is going on there.

Ron2 commented 9 years ago

Never mind about that unit test -- it fails in our current release and in our work-in-progress branch on my computer. I suspect it's somehow related to Windows 8.1 or my laptop somehow. Anyway, I merged in your changes. Thanks again!

twainj commented 9 years ago

Thanks Ron,

Glad to help. I've been really impressed with ATF, and have enjoyed being able to contribute. Hope to do so again in the future when the need arises!

Cheers,

Jason

On 6/9/2015 6:03 PM, Ron wrote:

Never mind about that unit test -- it fails in our current release and in our work-in-progress branch on my computer. I suspect it's somehow related to Windows 8.1 or my laptop somehow. Anyway, I merged in your changes. Thanks again!

— Reply to this email directly or view it on GitHub https://github.com/SonyWWS/ATF/pull/40#issuecomment-110549645.