minor improvements for FlagsUITypeEditor and FlagsTypeConverter

SonyWWS / ATF

Authoring Tools Framework (ATF) is a set of C#/.NET components for making tools on Windows. ATF has been in continuous development in Sony Computer Entertainment's (SCE) Worldwide Studios central tools group since early 2005. ATF has been used by most SCE first party studios to make many custom tools such as Naughty Dog’s level editor and shader editor for The Last of Us, Guerrilla Games’ sequence editor for Killzone games (including the Killzone: Shadow Fall PS4 launch title), an animation blending tool at Santa Monica Studio, a level editor at Bend Studio, a visual state machine editor for Quantic Dream, sound editing tools, and many others.

Apache License 2.0

1.89k stars 262 forks source link

minor improvements for FlagsUITypeEditor and FlagsTypeConverter #58

Closed jethac closed 7 years ago

jethac commented 8 years ago

As per topic, some minor fixes / improvements for flags handling. I've provided them as separate commits for clarity and ease of selective merging if some of what I'm doing here doesn't pass muster. :)

3107b8c: FlagsUITypeEditor can be set up on a property of type uint but when used that way, the checked list box isn't populated properly from the underlying value
5033c64: throw an exception when an object that isn't int or uint is passed in
dbd06d5: FlagsTypeConverter has a ConvertFrom function that parses enum literals into their underlying values. It feels like it'd be good to support integer literals here too - just type 6 for 4 | 2, etc

Thanks for making this open source, by the way! It's been hugely helpful for my team.

abeckus commented 8 years ago

Hi Jetha Thanks for making the improvements and I will merge them when I get a chance. I also fixed a bug in FlagsUITypeEditor in our local branch that needs to be merge to master branch. There are few pending ATF and LevelEditor local changes that need to be merged with master branch. Alan

jethac commented 8 years ago

Cheers Alan! :smile:

jethac commented 7 years ago

Hey Alan :) Any chance we could get these merged?

abeckus commented 7 years ago

Hi Jetha, I will try to take few cycles from other work to address ATF and LevelEditor pending merges. Currently ATF and LevelEditor are in low priority maintenance mode.

Alan

abeckus commented 7 years ago

merged to master branch.