search

Sooraj-beep / sherp2.0

9 stars 23 forks source link

Full course description feature #49

Closed nathandrapeza closed 1 year ago

aarctan commented 1 year ago

We should avoid making http requests like this, it will be slow and can be spammed. can you extend ualberta.ca.json to include descriptions?

Sooraj-beep commented 1 year ago

Bet you could write a script for it

nathandrapeza commented 1 year ago

Thanks for the feedback, will fix soon :-)

nathandrapeza commented 1 year ago

Some issues with unicode - looking into it

nathandrapeza commented 1 year ago

Some issues with unicode - looking into it

Looks like the ualberta.ca.json has unicode escape sequences for French accented characters (as far as I can tell), but when they're loaded in by python they work fine

Sooraj-beep commented 1 year ago

LGTM. Can't test on my end so if someone else also wants to review feel free to do so.