search

Sopel97 / chess_pos_db

Database software for chess position statistics. Designed to provide high performance and handle billions of games.
MIT License
3 stars 4 forks source link

mixed up Bitboard rank and file? #16

Closed Sopel97 closed 4 years ago

Sopel97 commented 4 years ago

https://github.com/Sopel97/chess_pos_db/blob/2e88d9388b414ec01b12c5064af3341e240999ef/src/chess/Bitboard.h#L91

shouldn't this be the other way around? a file has contiguous bits.

edit. actually the comment seems to be wrong, square is consistent with this

this would mean square to string is wrong. values is in the wrong order. flipVertically/Horizontally are wrong. file(),rank() could use bitwise ops.

Sopel97 commented 4 years ago

fixed in https://github.com/Sopel97/chess_pos_db/commit/9c5dbb9aea7754855218c6f4870d297c24519e17 and previous