SophistSolutions / WhyTheFuckIsMyNetworkSoSlow

WhyTheFuckIsMyNetworkSoSlow is a network performance analysis tool, making it easy to quickly examine a network and see what is wrong, and to evaluate longer term trends.
15 stars 1 forks source link

new precednce logic isnt great (fix with name/names (with precednece) and name is readonly entry with top precednece) #38

Closed LewisPringle closed 1 year ago

LewisPringle commented 2 years ago

my new precednce logic isnt great. Trouble is - takes a while to get good names from devices. So we revert to latest known name, instead of best found ever name.

best seen in debug builds were stuff like sonos speakers ahve bad names til the active device gets its ssdp message, and then it gets better.

Trouble is the Patch logic to compute derived names is done in discovery code, not in rolled up device code????

> MAYBE have 
    names : [ name: x, quality-score: n ]
    and name - a property that computes best?
    on C++ side, and maybe - unclear - don't export alias names? Maybe useful to export them too for same reason - so differnt sources can better merge/pick names.
LewisPringle commented 1 year ago

done but testing...

LewisPringle commented 1 year ago

fixed