Sorien / silex-idea-plugin

Idea plugin for Silex Framework - plugin is not compatible with PHPStorm 2016.2

MIT License

26 stars 8 forks source link

Move pimple.json to .idea folder? #20

Closed CarsonF closed 8 years ago

CarsonF commented 9 years ago

Seems like the .idea folder would be a better place for this file since it's only for the IDE

Sorien commented 9 years ago

.idea folder is hidden in PHPStorm as I remember and i wanted to make it editable by user.

CarsonF commented 9 years ago

It is hidden.

1) Hmmm interesting, never thought about editing it manually I just use the service provider. Also, maybe hidden is a good thing...I don't really want to see it :)

2) Usually people ignore the .idea folder, but since it's not there it would be one more thing to exclude.

Maybe both locations could be checked? Root first, then idea folder.

Sorien commented 9 years ago

i want to make it configurable in plugin settings ... i'll think about moving to another location

CarsonF commented 9 years ago

Sounds good

Sorien commented 9 years ago

25

CarsonF commented 9 years ago

I don't think #25 applies to this. That file suggested could still be in the .idea folder.

I still like the idea that both could be supported

Sorien commented 9 years ago

yes you are right, its just note for me ... i just want to decide what do do with this with introduction of new format.

Sorien commented 8 years ago

comitted