Sorien / silex-idea-plugin

Idea plugin for Silex Framework - plugin is not compatible with PHPStorm 2016.2
MIT License
26 stars 8 forks source link

Go To Declaration doesn't work #3

Closed CarsonF closed 9 years ago

CarsonF commented 9 years ago

I can't go to declaration of Foo::bar method directly from offsetGet

$app['foo']->bar();
Sorien commented 9 years ago

if you mean this image

as far as i know it can't be done (i've tried it today) there is no extension point for this :/

CarsonF commented 9 years ago

Really? Sad day :disappointed:

Is there also no extension point for parameter info? screen shot 2015-06-08 at 12 51 44 pm

Sorien commented 9 years ago

yes its same problem because i can't set type to $app[''] directly i have to set type for $app['']->foo() and so function foo don't know it's base class type (no inspection/parameter info/goto and so on)(autocomplete is working only because its a bit hacked to right place)

if you try $app['request']->attributes->add(); you will see that you can't CTRL + CLICK to attributes but inside add it works without problem

only possible solution is:

$request = $app['request'];
$request->attributes->add();
Sorien commented 9 years ago

hmm weird I just tried it again and it's working for me :D .. .please try https://github.com/Sorien/silex-idea-plugin/releases/tag/0.9.3

CarsonF commented 9 years ago

Schweeeeet! Updated plugin versions aren't showing on plugins.jetbrains.com or phpstorm, does each version have to be manually sent to them?

Sorien commented 9 years ago

yes, i just want somebody to test it before i'll send it

CarsonF commented 9 years ago

I can test it if you can walk me through the build process

On Tue, Jun 9, 2015 at 9:03 AM, Stano Turza notifications@github.com wrote:

yes, i just want somebody to test it before i'll send it

— Reply to this email directly or view it on GitHub https://github.com/Sorien/silex-idea-plugin/issues/3#issuecomment-110365147 .

Sorien commented 9 years ago

just download zip archive (silex-plugin.zip) from https://github.com/Sorien/silex-idea-plugin/releases/tag/0.9.3, uninstall old version and install new from disk image

CarsonF commented 9 years ago

screen shot 2015-06-09 at 9 13 06 am

Maybe the plugin.xml file needs to be updated?

Sorien commented 9 years ago

Yes, it seems so. I'll rebuild it when i get home (in 30 mins)

Sorien commented 9 years ago

pls try again https://github.com/Sorien/silex-idea-plugin/releases/tag/0.9.4

CarsonF commented 9 years ago

This is beautiful! Just beautiful! You've made my month good sir! :+1: :100: