SorkinType / Gelasio

SIL Open Font License 1.1
38 stars 2 forks source link

1.008 review #7

Closed moyogo closed 11 months ago

moyogo commented 1 year ago

hturned, mturned

ɥɯ uq in Gelasio

Mturned

The uppercase can have multiple forms:

While the character was encoded for Zhuang and Bouyei, in Unicode and most fonts it doesn’t have the shape that was actually used (Ш-shape). In the mean time, the letter has been adopted in a couple of orthographies with the scaled-up lowercase shape.

With either form, the letter is typically wider than M or W, like Ш typically is. It should definitely be wider here.

Compare for example WШM in Georgia

WШM in Georgia

with WƜM in Gelasio

WƜM in Gelasio Regular

Khook, Yhook

yhook

ƴ in Gelasio Regular is a bit to thick on the stem before the hook terminal.

279337589-a3c4f3ad-4f9f-4858-b5da-eab177658f3b

The hook could probably by made more pronounced like for the capital. It could be raised a little bit. In context it is a bit too close to y so one of those too strategies would help.

Oopen and oopen

Esh

Esh can have the ʃ-shape in Guinea languages or in Gabon languages. It’s not clear how much these orthographies are used but in Guinea it’s still the official national alphabet. The Sigma-shape was used in orthographies that don’t use the letter anymore (Ga before the 1960s or Xhosa before 1955).

I’d recommend using the ʃ-shape adjusted to caps.

upsilon-latin

ʊ would fit better as a lowercase if it wasn’t a direct small-caps (or petite-caps) of its capital Ʊ.

For example

ʊ in Gelasio Regular

Compare in a word:

Screenshot 2023-10-31 at 14 50 36

Eng

The new default Eng is too narrow compare to other capitals and its right sidebearing is too narrow.

Ŋ in Gelasio Regular Ŋ in Gelasio Bold

Missing anchors

The following glyphs are letter and don’t have anchors:

Dcroat
Delta
Dtail
Dcroat
Delta
Eng
Esh
Eth
Germandbls
Mturned
OE
Omega
Saltillo
Schwa
Tbar
Thorn
Upsilon-latin
Vturned
bilabialclick
dcroat
dhook
eng
eth
eturned
germandbls
hbar
j
kgreenlandic
ldot
mu
obarred
pi
saltillo
tbar
thorn
upsilon-latin
vturned

/Schwa/schwa/eturned/Eng/eng/Mturned/mturned/obarred/OE/oe/Upsilon-latin/upsilon-latin/Vturned/vturned definitely need anchors as they are used with accents in orthographies. The others may as well in some transcription systems but are not top priority so it’s fine for now.

Missing uppercase

The uppercase of some glyphs included is missing: /hturned/obarred.

.loclMAH variants

/Lcommaaccent.loclMAH/lcommaaccent.loclMAH/Ncommaaccent.loclMAH/ncommaaccent.loclMAH should have a cedilla-shaped like the cedilla under O or M in Marshallese. Currently O and M get a "normal" cedilla but the .loclMAH use the same comma-shape cedilla as the Latvian letters.

ĻļŅņ  Ḩḩ in Gelasio

Regenerate them with:

L+cedillacomb.case=Lcommaaccent.loclMAH
l+cedillacomb=lcommaaccent.loclMAH
N+cedillacomb.case=Ncommaaccent.loclMAH
n+cedillacomb=ncommaaccent.loclMAH

Optionally the cedillacomb could be centered on the stem like on Ḩ ḩ. The Marshallese dictionary has it centered on the stem in some instances.

Dutch NLD locl feature and /Jacute/jacute

The /Jacute/jacute NLD locl feature hack is a horrible practice. It adds an acute on j when it follows an iacute in Dutch. Users should use the combining acute with j if they want the acute on j.

The spelling rule clearly says the acute on j is usually omitted and shows an example. Fonts with this hack cannot display the text of the rule itself in a meaningfull way.

Adding an acute when it’s not there breaks text that is intentionally spelled a certain way. A third to a half of Dutch speakers spell with rules from before 1996 when putting two acutes became the norm, before that putting a single acute on vowels composed of different letters was very common. It still is common, it just doesn’t follow the non mandatory official rules.

Remove /Jacute/jacute and re-generate the locl feature. Alternatively /Jacute/jacute could be renamed /J_acutecomb/j_acutecomb and a ligature substitution could be added but the ccmp feature already substitute j by jdotless when combined with top marks.

calt feature

Remove the calt feature as it is.

sub Iacute Jacute by IJ_acutecomb;
sub I acute by Iacute;
sub J acute by Jacute;
sub iacute jacute by ij_acutecomb;
sub i acute by iacute;
sub j acute by jacute;

You don’t want the spacing acute to function like the combining acute. When used, the spacing acute is used as a spacing character.

You don’t want iacute jacute to form a ligature (single glyph). Even if that were in the Dutch locl feature, that would be problematic in particular as i j are not substituted by ij in this font.

moyogo commented 1 year ago

For Gelasio-Italic, the same comments apply. Additionally:

Bhook, Dhook

The hook seems larger than in Italic and Bold Italic masters than in Regular and Bold masters. This can be OK I guess, just making sure it is intentional.

NeilSureshPatel commented 1 year ago

Now that you have the alternate Eng you should 3 more Sami language tags in the locl feature to use the "capital N" style alternate.

    language ISM;
    sub Eng by Eng.loclNSM;
    language SKS;
    sub Eng by Eng.loclNSM;
    language LSM;
    sub Eng by Eng.loclNSM;
EbenSorkin commented 1 year ago

I have completed these fixes I think and added Ɛ Ʒ Ǯ Ǥ ɛ ʒ ǯ ǥ Please have a look.

NeilSureshPatel commented 12 months ago

It looks like you got all of the fixes from above with the exception of the following:

Open E

The Ɛ looks light and narrow in the regular upright. I can see the left side being about 20 units heavier, closer to the weight of the bowls of the B. In addition, whole character could be about 20 units wider.

Screen Shot 2023-11-02 at 7 56 44 PM Screen Shot 2023-11-02 at 7 59 25 PM
EbenSorkin commented 11 months ago

I think these are all done now too. Thanks Neil!