search

SorkinType / Merriweather

Merriweather is a serif typeface. It is offered in Variable font format and static formats ( OTF, TTF WOFF etc).
SIL Open Font License 1.1
278 stars 20 forks source link

Fix starting points #557

Open m4rc1e opened 1 year ago

m4rc1e commented 1 year ago

I've fixed the interpolation issues in #540 via scripting. @EbenSorkin fonts have been regenned as well.

@kenmcd would you mind reviewing the regenned fonts in this pr?

Cogli commented 1 year ago

Using Merriweather-Italic[opsz,wdth,wght].ttf from this PR, WGHT:900 and WDTH:87 : 2023-07-14 135746 Some misplaced anchor, it seems.

Some other glyphs have similar issues, but for different values of WGHT and WDTH, so it will be more difficult to identify the defective master for those.

m4rc1e commented 1 year ago

Thanks @Cogli. I'll checkout a previous commit to see if I haven't introduced this change.

Cogli commented 1 year ago

Thanks @Cogli. I'll checkout a previous commit to see if I haven't introduced this change.

Done! It is not a case of regression, issue already visible in v 2.200

m4rc1e commented 1 year ago

What app/page are you using to check this?

Cogli commented 1 year ago

Screenshot from dinamo font gauntlet.

kenmcd commented 1 year ago

@kenmcd would you mind reviewing the regenned fonts in this pr?

Sure. Will be at my computer in about 3 hours from now. Will do it then.

kenmcd commented 1 year ago

@m4rc1e The start point issues appear to be resolved for those glyphs I included in https://github.com/SorkinType/Merriweather/issues/540. But other issues remain - element order issues and the moving diacritics issues. Think I can see the source of both those problems. And can document it with images.

Do you want to have that conversation here? Or should I make a new v2.300PR issues post? There are also a few other issues I can see which should be addressed.

m4rc1e commented 1 year ago

Let's keep them in this pr. Makes things it easier to manage!

Thanks for checking! this is gold.

kenmcd commented 1 year ago

OK... "I'll be back."

Cogli commented 1 year ago

I'm sorry, I do not have access to the .glyphs sources, so I can't really be of help in diagnosing or solving the problem. Many thanks to you!

kenmcd commented 1 year ago

These are all for this PR v2.300 Italic

Element Order issue - hungarumlautcomb.case /Ohungarumlaut/Uhungarumlaut/Uacutedblcyr/hungarumlautcomb.case Different element order in some of the Light masters Looks like - Light, LightDisplay, SemiExpandedLightDisplay
Element-Order-hungarumlautcomb case-2023-07-14_10-57-35

/dieresiscombcy.case Has a width in some masters. width-dieresiscombcy case-2023-07-14_11-18-58

/Lcaron The caron overlaps the L at minimum opsz (7) Lcaron-overlap-2023-07-14_11-05-28

Diacritics offset As you can see in @Cogli 's post above. Many different glyphs have big offsets on the diacritic elements. Mostly appear to be in the various "Black" masters. If you can filter to find large X offsets, that would find these. (and probably find some that I missed)

Black7pt master /abrevegrave/abrevehoi/abrevetilde/acaron/acircumflex/acircumflexacute/acircumflexdotbelow/acircumflexgrave/acircumflexhoi/acircumflextilde/adblgrave/adieresis/agrave/ainvertedbreve/amacron/aring/atilde /umacroncyr/udieresiscyr/uacutedblcyr

Black144 master /ccaron/dzcaron/ezhcaron/gcaron/ucaron/zcaron/Dzcaron /ishortcyr.sc/igravecyr.sc/kjecyr.sc

SemiExpandedBlackSmall master /zacute/zcaron/zdotaccent

Going to scan the Italic again to see if anything jumps out. Then going to take another look at the Roman. IIRC I did not see anything with v2.200, but should check it.

kenmcd commented 1 year ago

Roman v2.300PR - Start Point issues

/dcroat/ordmasculine/Estailcyr/djecyr/yusbigcyr/zero.tf.zero

Roman-Start-Point-issues 2023-07-14_14-49-03

kenmcd commented 1 year ago

Regarding using tabular figures for a tabular report... Is there any concern that: The figurespace (U+2007) width does not match the tabular figures width? And the punctationspace (U+2008) width does not match either the period or the comma width?

m4rc1e commented 1 year ago

@kenmcd Fantastic review! thank you so much for doing this!

@EbenSorkin I think it may be easier for us to ignore this PR and just make sure that these issues are solved in the African update

EbenSorkin commented 1 year ago

Does the PR fix this or just list the issues?

It should be fast to fix a misplaced anchor and to resolve the interpolation issues I see in this thread.

If they are not done I am happy to do the fixes today.

-e.

On Mon, Jul 17, 2023 at 6:47 AM Marc Foley @.***> wrote:

@kenmcd https://github.com/kenmcd Fantastic review! thank you so much for doing this!

@EbenSorkin https://github.com/EbenSorkin I think it may be easier for us to ignore this PR and just make sure that these issues are solved in the African update

— Reply to this email directly, view it on GitHub https://github.com/SorkinType/Merriweather/pull/557#issuecomment-1637871401, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQUQXOKGWIIH4NOP6D7KZTXQUJ5ZANCNFSM6AAAAAA2KDXYBU . You are receiving this because you were mentioned.Message ID: @.***>

m4rc1e commented 1 year ago

Does the PR fix this or just list the issues?

This PR only fixes the starting points issues for the Italic and Roman (just done this one now) sources. This has fixed issues such as https://github.com/SorkinType/Merriweather/pull/557#issuecomment-1636481639. It doesn't fix the misplaced Anchors.

Please merge this PR, then fix the anchors. If your git skills are good enough, just add commits to this pr to fix the anchors.