search

Sorrow446 / Napster-Downloader

Napster downloader written in Go.
23 stars 3 forks source link

Corrupted AAC tracks. #2

Closed Sorrow446 closed 5 months ago

Sorrow446 commented 2 years ago

My tagger doesn't play well with AAC tracks from Napster. The Atom tree looks fine, so not sure on the cause.

thefarmboy25 commented 1 year ago

The issue might be in writing the tags. I downloaded an album in 192 AAC and all the tracks were corrupt and wouldn't play besides one where it failed to write the tags, that song works fine. Re-downloading the song where the tags wrote successfully corrupted the song. Maybe disable tags for AAC tracks and see if that fixes the problem?

Sorrow446 commented 1 year ago

The tag writing is the problem. There's something weird about Napster's AACs I can't figure out.

Sorrow446 commented 8 months ago

Plan to fix soon, know the problem.

damarges commented 6 months ago

Plan to fix soon, know the problem.

any plans when this could be fixed?

Sorrow446 commented 6 months ago

I rewrote my own MP4 (AAC) tagger for it, but https://github.com/Sorrow446/go-mp4tag/issues/9 might be a problem for Napster's tracks. I don't remember if they have those boxes. I'll try implementing it today, but it's been trouble.

Would be great if I could borrow your account to test. Send it over Discord if possible.

Sorrow446 commented 5 months ago

Fixed. https://github.com/Sorrow446/Napster-Downloader/commit/9b4562b470f8a344d66ef0aae6dd1309d0182909