search

SortableJS / angular-legacy-sortablejs

AngularJS (legacy) directive for SortableJS.
49 stars 49 forks source link

Regression in 0.6.2? #43

Open chrispbailey opened 5 years ago

chrispbailey commented 5 years ago

The move away from env.clone on this line:https://github.com/SortableJS/angular-legacy-sortablejs/compare/8e2f1c97897da91ab373537b47551cabfab2e078..master#diff-fd07c4295c44d1bcf1aaf3d5862c0afbL115 caused an issue dragging and dropping between multiple sortable lists. The source list's order gets shuffled around (see attached video).

sortable_bug

samjacobclift commented 5 years ago

hmm someone did request this to be changed to that, is the issue caused because the check fails or because it passes?

perhaps we could change it to an or

if ((evt.clone) || (Sortable.active && Sortable.active.lastPullMode === 'clone')) {