search

SortableJS / ngx-sortablejs

Angular 2+ binding to SortableJS. Previously known as angular-sortablejs
https://sortablejs.github.io/ngx-sortablejs/
MIT License
465 stars 160 forks source link

Support Angular 12 #242

Open nunoarruda opened 2 years ago

nunoarruda commented 2 years ago

Looks to be working ok with Angular 12 but there's a warning on npm install about peer dependencies:

npm WARN ngx-sortablejs@11.1.0 requires a peer of @angular/common@^11.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN ngx-sortablejs@11.1.0 requires a peer of @angular/core@^11.0.0 but none is installed. You must install peer dependencies yourself.
Anikethana commented 2 years ago

pull request https://github.com/SortableJS/ngx-sortablejs/pull/246

nunoarruda commented 2 years ago

Node.js LTS version is now v16.x which includes npm v8.x. These versions will error out on npm install if there is an incorrect (and potentially broken) dependency resolution which looks to be the case with ngx-sortablejs:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: pulse-angular@5.2.4
npm ERR! Found: @angular/common@12.2.12
npm ERR! node_modules/@angular/common
npm ERR!   @angular/common@"~12.2.11" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer @angular/common@"^11.0.0" from ngx-sortablejs@11.1.0
npm ERR! node_modules/ngx-sortablejs
npm ERR!   ngx-sortablejs@"^11.1.0" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /Users/nunoarruda/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/nunoarruda/.npm/_logs/2021-11-02T15_53_02_208Z-debug.log

Workaround: use npm install --force or npm install --legacy-peer-deps.

@smnbbrv can you please fix this when you have a chance?

arimus commented 2 years ago

It might be appropriate to not depend on a specific version of Angular and do a greater than the min requirements as a peer dependency instead? Would prevent having to create new builds for every Angular release.

imtiazShakil commented 1 year ago

is this project dead?

nunoarruda commented 1 year ago

At this stage, it looks like this project is pretty much dead and/or abandoned. I suggest you folks give these alternatives a try:

https://material.angular.io/cdk/drag-drop/overview (for mixed direction, follow MikaStark workaround) https://valor-software.com/ng2-dragula/ https://kreuzerk.github.io/ng-sortgrid/

COBRASoft5 commented 1 year ago

cdk doesn't work with grids dragula also dead sortgrid doesn't cut it

SortableJs is the best available, but it needs to be maintained :(

Deitsch commented 1 year ago

Yes, it's dead. I'd suggest https://github.com/ThibaultJanBeyer/DragSelect as alternative

SylvainUMI commented 1 year ago

Holly shit it's too bad ....

nzbin commented 12 months ago

Hi, folks, I suggest you can try the ng-dnd library and it's very easy to solve the mixed direction issue (https://github.com/angular/components/issues/13372), please check the following example: https://stackblitz.com/edit/867pxw?file=src%2Fexample%2Fchips-drag-drop-example.html