search

SortableJS / ngx-sortablejs

Angular 2+ binding to SortableJS. Previously known as angular-sortablejs
https://sortablejs.github.io/ngx-sortablejs/
MIT License
467 stars 160 forks source link

Angular 6 issue compatibility #245

Open bashayerAlsalman opened 3 years ago

bashayerAlsalman commented 3 years ago

When using the latest version of ngx-sortablejs with angular 6.

this error come across while running the project

ERROR in node_modules/ngx-sortablejs/lib/sortablejs.directive.d.ts(25,17): error TS1086: An accessor cannot be declared in anambient context. node_modules/ngx-sortablejs/lib/sortablejs.directive.d.ts(26,17): error TS1086: An accessor cannot be declared in an ambient context. node_modules/ngx-sortablejs/lib/sortablejs.directive.d.ts(28,17): error TS1086: An accessor cannot be declared in an ambient context. node_modules/ngx-sortablejs/lib/sortablejs.directive.d.ts(30,17): error TS1086: An accessor cannot be declared in an ambient context. node_modules/ngx-sortablejs/lib/sortablejs.module.d.ts(4,45): error TS2315: Type 'ModuleWithProviders' is not generic.

nandita121189 commented 2 years ago

@bashayerAlsalman Any update on your end?

I am getting a similar issue while integrating with Angular 5

I tried integrating this library with Angular 5. On doing npm install(as suggested in Readme) I got the below versions "ngx-sortablejs": "^11.1.0", "sortablejs": "^1.14.0", "@types/sortablejs": "^1.10.7",

But after including it in Angular I get the below error

ERROR in node_modules/ngx-sortablejs/node_modules/tslib/tslib.d.ts(49,82): error TS2304: Cannot find name 'unknown'.
node_modules/ngx-sortablejs/node_modules/tslib/tslib.d.ts(67,82): error TS2304: Cannot find name 'unknown'.
node_modules/ngx-sortablejs/node_modules/tslib/tslib.d.ts(76,96): error TS2304: Cannot find name 'unknown'.
node_modules/ngx-sortablejs/node_modules/tslib/tslib.d.ts(85,82): error TS2304: Cannot find name 'unknown'.
node_modules/ngx-sortablejs/node_modules/tslib/tslib.d.ts(85,121): error TS2304: Cannot find name 'unknown'.
node_modules/ngx-sortablejs/node_modules/tslib/tslib.d.ts(96,55): error TS2304: Cannot find name 'unknown'.
node_modules/ngx-sortablejs/node_modules/tslib/tslib.d.ts(103,82): error TS2304: Cannot find name 'unknown'.
node_modules/ngx-sortablejs/node_modules/tslib/tslib.d.ts(123,82): error TS2304: Cannot find name 'unknown'.
node_modules/ngx-sortablejs/lib/sortablejs.directive.d.ts(25,17): error TS1086: An accessor cannot be declared in an ambient context.
node_modules/ngx-sortablejs/lib/sortablejs.directive.d.ts(26,17): error TS1086: An accessor cannot be declared in an ambient context.
node_modules/ngx-sortablejs/lib/sortablejs.directive.d.ts(28,17): error TS1086: An accessor cannot be declared in an ambient context.
node_modules/ngx-sortablejs/lib/sortablejs.directive.d.ts(30,17): error TS1086: An accessor cannot be declared in an ambient context.
node_modules/ngx-sortablejs/lib/sortablejs.module.d.ts(4,45): error TS2315: Type 'ModuleWithProviders' is not generic.
nandita121189 commented 2 years ago

@bashayerAlsalman did it work for u in angular 6?

bashayerAlsalman commented 2 years ago

@nandita121189 apologize for the late replay, I used primeng/dragdrop instead.