Sorunome / arduino-upload

Atom Package for those who don't like the Arduino IDE
https://atom.io/packages/arduino-upload
MIT License
34 stars 7 forks source link

Option to automatically save file before upload please #37

Closed stibinator closed 6 years ago

stibinator commented 6 years ago

I can't count the number of times I've uploaded something and spent ages trying to work out why the changes I've made to the code didn't do anything. Then I realise that I didn't save before the last upload.

Could you please implement at least an option to automatically save before uploading, to make your fine package even finer. Thanks

StaticRocket commented 6 years ago

I have a PR open ( #38 ) that makes "save active tabs" a toggleable setting that is disabled by default. It closes the serial monitor and saves all active tabs before building/uploading/verifying. Is there anything else you think I should address with this system?

stibinator commented 6 years ago

Sounds like a plan. Defaulting to the current behaviour is probably the best way to introduce it.

Does the serial monitor automatically re-open? It would be annoying if you want to say, monitor how your script initialises and you had to manually re-open the serial monitor after uploading.

StaticRocket commented 6 years ago

I added a toggle to specify whether or not to reopen the serial monitor if it was open previously and Autosave is enabled as well.