search

Sorunome / arduino-upload

Atom Package for those who don't like the Arduino IDE
https://atom.io/packages/arduino-upload
MIT License
34 stars 7 forks source link

Save all active tabs before build and upload #38

Closed StaticRocket closed 6 years ago

StaticRocket commented 6 years ago

Proposing the change to run window:save-all command before beginning the upload or building process. Unfortunately this needs to close the serial monitor to avoid saving its output in the project directory. Resolves #37

Sorunome commented 6 years ago

It would be good if this was a configurable option. I personally don't like autosave at all.

Aaaaand some way to figure out how to not autosave the serial monitor.

Other than that, thanks for the PR!

StaticRocket commented 6 years ago

I'll look at making a toggle for it, as for the serial monitor being saved issue I just called on the close serial function before saving.

Sorunome commented 6 years ago

Oh, right, serial is closed before upload anyways, so that should work

StaticRocket commented 6 years ago

Made it a toggleable setting in package settings. Defaults to false.

Sorunome commented 6 years ago

please leave open until the PR is merged (so until i find time to test and stuff)

StaticRocket commented 6 years ago

Sorry, I had closed it because I was going to attempt to completely reconfigure the settings so they would support things like a drop-down selection list for line ending types and some other things. I suppose that was silly of me.

Sorunome commented 6 years ago

Thank you for the PR! Sorry it took so long for me to get back to it :[