search

Sorunome / arduino-upload

Atom Package for those who don't like the Arduino IDE
https://atom.io/packages/arduino-upload
MIT License
34 stars 7 forks source link

Windows Build Tools Dependency #52

Closed StaticRocket closed 5 years ago

StaticRocket commented 6 years ago

Why does this seem to require windows build tools for the initial install? I don't believe it has anything to do with Python and the only way I see it needing MSVS is if something was being compiled during install. Obviously there must be some way to work around this or users would have reported a similar experience with other Atom packages. Submitting this issue for idea spitballing.

Sorunome commented 6 years ago

Why does this seem to require windows build tools for the initial install?

Because of the serialport dependency version this is using (4.0.7, was newest at the time of writing) only provided pre-builts for node.js runtime, not for electron runtime.

The fix would probably be to update to the (by now) newest serialport version, which also provides electron builds. That, unfortunately, takes time I currently don't have. I'd be happy for anyone wanting to help.

StaticRocket commented 6 years ago

I'd offer to help, but I have little to no experience with Electron. I wouldn't want to get in the way.

Sorunome commented 6 years ago

That shouldn't be a problem, apm does all that stuff for you. So it's only about migrating serialport to newest version (incompatiple APIs)

Am 18. Juli 2018 17:06:14 MESZ schrieb StaticRocket notifications@github.com:

I'd offer to help, but I have little to no experience with Electron. I wouldn't want to get in the way.

-- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/Sorunome/arduino-upload/issues/52#issuecomment-405964451

StaticRocket commented 6 years ago

@Sorunome Well... I'm still working on figuring out where to start with the serialport-builds-electron upgrade, but I think I've solved the serialport installation issue you mentioned in that one error message. I installed it by listing it as a package dependency and sending Update Package Dependencies: Update through Atom's Command Palette while in dev mode for the package.

Sorunome commented 6 years ago

You'll need the newest serialport package. serialport-builds-electron is my own fork for literally this atom package only, which only provides some more pre-builts.

Am 18. Juli 2018 21:13:14 MESZ schrieb StaticRocket notifications@github.com:

@Sorunome Well... I'm still working on figuring out where to start with the serialport-builds-electron upgrade, but I think I've solved the serialport installation issue you mentioned in that one error message. I installed it by listing it as a package dependency and sending Update Package Dependencies: Update through Atom's Command Palette while in dev mode for the package.

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/Sorunome/arduino-upload/issues/52#issuecomment-406042901