Sorunome / arduino-upload

Atom Package for those who don't like the Arduino IDE
https://atom.io/packages/arduino-upload
MIT License
34 stars 7 forks source link

Flex-bar buttons does not work... #60

Closed StefanMeGit closed 5 years ago

StefanMeGit commented 5 years ago

I installed everything and the flexbar works, but I can't use the buttons u described... when go over PACKAGES - ARDUNIO UPLOAD - VERIFY everything works as expected.

The just do nothing... other buttons like new-file working good. Any idea?

  {
    type: "button"
    icon: "file-add"
    tooltip: "New File"
    callback: "application:new-file"
  }
  {
    type: "button"
    icon: "check"
    callback: ["core:save", "arduino-upload:verify"]
    tooltip: "Arduino: Verify",
    enable: { grammar: "arduino" }
  }
  {
    type: "button"
    icon: "arrow-right"
    callback: ["core:save", "arduino-upload:upload"]
    tooltip: "Arduino: Upload",
    enable: { grammar: "arduino" }
  }
  {
    type: "button"
    icon: "terminal"
    callback: "arduino-upload:serial-monitor"
    tooltip: "Arduino: Serial monitor",
    enable: { grammar: "arduino" }
  }
  {
    type: "spacer"
  }
  {
    type: "button"
    icon: "gear"
    callback: "flex-tool-bar:edit-config-file"
    tooltip: "Edit Tool Bar"
  }
StaticRocket commented 5 years ago

It looks like you forgot to separate each section and subsection with commas. If you're using JS config, it should look like this:

{
    type: "button",
    icon: "check",
    callback: ["core:save", "arduino-upload:verify"],
    tooltip: "Arduino: Verify",
    enable: { grammar: "arduino" }
  },
  {
    type: "button",
    icon: "arrow-right",
    callback: ["core:save", "arduino-upload:upload"],
    tooltip: "Arduino: Upload",
    enable: { grammar: "arduino" }
  },
  {
    type: "button",
    icon: "terminal",
    callback: "arduino-upload:serial-monitor",
    tooltip: "Arduino: Serial monitor",
    enable: { grammar: "arduino" }
  },
  {
    type: "spacer"
  },
  {
    type: "button",
    icon: "gear",
    callback: "flex-tool-bar:edit-config-file",
    tooltip: "Edit Tool Bar"
  }

Also, you don't need to use core save, I kind of made an option that can do this automatically on build/verification.

If this isn't applicable, what config are you using? Flex-Toolbar supports the cson, json, json5, js, and coffee file extension and the associated syntax.

jrial commented 5 years ago

In that case someone needs to fix the documentation at https://github.com/Sorunome/arduino-upload/blob/v1.4.1/docs/toolbar.md

I was already wondering why there were no commas in the cson.