search

Sorunome / arduino-upload

Atom Package for those who don't like the Arduino IDE
https://atom.io/packages/arduino-upload
MIT License
34 stars 7 forks source link

Install issues associated with serialport and VS2017 #67

Open metatron197 opened 5 years ago

metatron197 commented 5 years ago

Was having problems that are well captured elsewhere (eg. #11), namely with the serialport package causing the install to fail. I tried to solve the problem by following the device in the readme .\npm install --global --production windows-build-tools, but ended up with the same string of errors and apparently problems with the serial port package.

Inspecting the windows-build-tools package revealed that the default version was 2017. However, adding the --vs2015 flag to the command allowed the install to work perfectly. Perhaps we can add this to the readme until the 2017 issues are worked out?

StaticRocket commented 5 years ago

Sounds like you didn't send apm config set msvs_version [VERSION] where [VERSION] was noted as being 2015 for the build-tools package. That being said, this does hint at the serialport package's latest release being unstable. I'll have to poke around.

If you want to try rolling back serialport on your install as a test, you can clone this repository and edit https://github.com/Sorunome/arduino-upload/blob/ee95b70365c2cd70c09c16f76c9a1bde8aab318c/package.json#L28 to "serialport": "^7.1.2", After that use apm install and apm link in the projects root directory to install the required dependencies and link it into atom's package directory.

metatron197 commented 5 years ago

I'm not sure it's that serialport is unstable so much as maybe it's not compatible with VS2017?

Hmm, I removed arduino-upload, and windows-build-tools, then put build tools back with .\npm install --global --production windows-build-tools (to get the 2017 version), but still set the version to 2015 in apm with apm config set msvs_version 2015, and now it installs just fine. It

Even if I remove both and install arduino-upload without reinstalling windows-build-tools, it still installs just fine. Idk what I was doing last night, but I'm not having any luck replicating it right now.