search

Sorunome / arduino-upload

Atom Package for those who don't like the Arduino IDE
https://atom.io/packages/arduino-upload
MIT License
34 stars 7 forks source link

CI and GreenKeeper #68

Open StaticRocket opened 5 years ago

StaticRocket commented 5 years ago

I'm looking at trying to get the /spec directory and some configs sorted out so we could potentially use Travis CI and GreenKeeper to try to limit issue sources. @Sorunome, do you think this is worth perusing? Right now (working in my fork), I've found that arduino-upload-view-spec.coffee introduces an impossible test, so I've removed. but arduino-upload-spec.coffee throws a few errors as well.

~$ apm test

FF

ArduinoUpload
  when the arduino-upload:toggle event is triggered
    it hides and shows the modal panel
      Expected '<div class="arduino-upload info-view" is="space-pen-div" style="display: none;"><button click="close" class="btn">close</button><pre></pre></div>' not to exist.
        at jasmine.Spec.<anonymous> (file:///C:/Users/Res/Desktop/arduino-upload/spec/arduino-upload-spec.coffee:19:66)
      TypeError: Cannot read property 'isVisible' of null
        at jasmine.Spec.<anonymous> (file:///C:/Users/Res/Desktop/arduino-upload/spec/arduino-upload-spec.coffee:35:31)
        at <anonymous>
    it hides and shows the view
      Expected '<div class="arduino-upload info-view" is="space-pen-div" style="display: none;"><button click="close" class="btn">close</button><pre></pre></div>' not to exist.
        at jasmine.Spec.<anonymous> (file:///C:/Users/Res/Desktop/arduino-upload/spec/arduino-upload-spec.coffee:48:66)
      Expected '<div class="arduino-upload info-view" is="space-pen-div" style="display: none;"><button click="close" class="btn">close</button><pre></pre></div>' to be visible.
        at jasmine.Spec.<anonymous> (file:///C:/Users/Res/Desktop/arduino-upload/spec/arduino-upload-spec.coffee:60:34)
        at <anonymous>

Finished in 0.215 seconds
2 tests, 7 assertions, 4 failures, 0 skipped

Tests failed
Sorunome commented 5 years ago

Automated tests are always a goo idea. Some of the tests seem to be wrong at first glance, as it expects e.g. the element to not exist when it actually has display:none;

StaticRocket commented 5 years ago

Alright, awesome. I'll poke around and see what I can figure out. I just wanted to see if this was something you'd be interested in, especially considering you ultimately control those integration settings. I'll leave this thread open in case any other questions regarding this come up.

StaticRocket commented 4 years ago

@Sorunome sorry for the silence. I've gotten dragged in a completely different direction by a number of things. Atom fell back on Electron4 (going against my rolling release mentality and pushing me to Neovim, a tool I had been using for quite some time now) and I've started playing with FPGAs, Assembly, Java, Machine Learning, and SysAdmin stuff to boot. I still intend on helping out wherever possible but this project is currently on the back-burner as I keep getting thrown stray projects at college.

One idea I had been working on for a revamp (to address several issues all at once) was to dump the Arduino IDE dependency and board selection stuff and just add hooks for Arduino-Makefile support. It would be a little jarring for current users but way faster and make board support and selection way cleaner. Just a thought. Best of luck with this project, dude.