search

Sorunome / mx-puppet-bridge

Puppeting library for matrix
Apache License 2.0
95 stars 29 forks source link

Report a human-readable device name to synapse #20

Closed ericmigi closed 4 years ago

ericmigi commented 4 years ago

Currently mx-puppet-bridges report a 10 char string for device_name to Synapse. Would be great to get human readable names in there.

Tulir recommends using a similar set up to his mautrix-python: https://github.com/tulir/mautrix-python/blob/master/mautrix/bridge/custom_puppet.py#L121 in this section: https://github.com/Sorunome/mx-puppet-bridge/blob/master/src/provisioner.ts#L56-L64

Currently synapse sees this:

synapse=# select * from user_daily_visits where user_id='@eric:eric.nova.chat' limit 100;
       user_id        |         device_id         |   timestamp   
----------------------+---------------------------+---------------
 @eric:eric.nova.chat | KOUXPAVMRD                | 1578009600000
 @eric:eric.nova.chat | KOUXPAVMRD                | 1578096000000
 @eric:eric.nova.chat | KOUXPAVMRD                | 1578182400000
 @eric:eric.nova.chat | KGVNHWZAWS                | 1578182400000
 @eric:eric.nova.chat | Facebook Messenger Bridge | 1578182400000
 @eric:eric.nova.chat | HOPOJLCOUX                | 1578182400000
 @eric:eric.nova.chat | Telegram Bridge           | 1578182400000
 @eric:eric.nova.chat | SYFQILRZEB                | 1578182400000
 @eric:eric.nova.chat | FVSOZAXDXY                | 1578182400000
 @eric:eric.nova.chat | Facebook Messenger Bridge | 1578268800000
 @eric:eric.nova.chat | KOUXPAVMRD                | 1578268800000
 @eric:eric.nova.chat | Telegram Bridge           | 1578268800000
 @eric:eric.nova.chat | FVSOZAXDXY                | 1578268800000
Sorunome commented 4 years ago

Done in https://github.com/Sorunome/mx-puppet-bridge/commit/1abef2679f625b92990b709b372b8c9ec7e32f9c

Obviously only affects new logins