search

Sorunome / mx-puppet-instagram

An instagram matrix puppeting bridge
Apache License 2.0
30 stars 13 forks source link

Add Instagram identifier to usernames #25

Closed rsre closed 2 months ago

rsre commented 3 years ago

In other bridges when you import the users from other chat service a string is attached to their names to show where they come from. For example, if I talk to Sorunome from Instagram it would show as "Sorunome (Instagram)".

Would it be possible to add this feature?

I'm not very familiar with Typescript or your library, but I've been looking at the source and maybe it could be added at line 67 of instagram.ts, something like: name: user.name + ' (Instagram)',

If you can confirm that makes sense I can create a Pull Request.

Have a nice day :)

Sorunome commented 3 years ago

you can already do that with the name patterns blovk in your config.yaml

    1. 2021 22:53:37 Ricardo notifications@github.com:

In other bridges when you import the users from other chat service a string is attached to their names to show where they come from. For example, if I talk to Sorunome from Instagram it would show as "Sorunome (Instagram)".

Would it be possible to add this feature?

I'm not very familiar with Typescript or your library, but I've been looking at the source and maybe it could be added at line 67 of instagram.ts, something like: name: user.name + ' (Instagram)',

If you can confirm that makes sense I can create a Pull Request.

Have a nice day :)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub[https://github.com/Sorunome/mx-puppet-instagram/issues/25], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AASSEVAV2WBA2CFFKCBAHR3S7BA5XANCNFSM4XTUNPZA]. [data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAEgAAABICAYAAABV7bNHAAAAAXNSR0IArs4c6QAAAARzQklUCAgICHwIZIgAAAArSURBVHic7cEBDQAAAMKg909tDjegAAAAAAAAAAAAAAAAAAAAAAAAAAA+DFFIAAEctgHwAAAAAElFTkSuQmCC###24x24:true###][Sledovací obrázek][https://github.com/notifications/beacon/AASSEVGNCRGTWUC7CJYKCZDS7BA5XA5CNFSM4XTUNPZKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4MBJ6PDA.gif]

rsre commented 3 years ago

I've tried to edit this part like this: namePatterns: user: :name + ' (Instagram)' userOverride: :name + ' (Instagram)' room: :name group: :name

but it doesn't seem to have the effect I'm hoping for... Can you point me to some further documentation about how to properly configure this?